fix(selfhost): recognize experimental: as a valid top-level manifest field#5307
Conversation
…field #5030 (the gittensor subnet plugin) added a real, actively-parsed experimental: top-level manifest block, but never updated this linter's TOP_LEVEL_FIELDS allowlist -- the same class of bug already fixed once in this file for repoDocGeneration (#3364). All 3 production self-host repo configs declare experimental: gittensor: true today; running the config-lint CLI against any of them produced a false "unknown top-level field" warning. Refs #5281
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5307 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 474 474
Lines 40128 40128
Branches 14631 14631
=======================================
Hits 37869 37869
Misses 1583 1583
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-12 13:49:42 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 4 non-blocking
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
#5030 (the gittensor subnet plugin) added a real, actively-parsed
experimental:top-level manifest block, but never updatedsrc/selfhost/config-lint.ts'sTOP_LEVEL_FIELDSallowlist — the same class of bug already fixed once in this exact file forrepoDocGeneration(#3364). All 3 production self-host repo configs declareexperimental: { gittensor: true }today; runningnpm run selfhost:config-lintagainst any of them produces a false "unknown top-level field" warning.Scope
src/selfhost/config-lint.ts(one line),test/unit/selfhost-config-lint.test.ts(regression test mirroring the #3364 precedent).Validation
npm run typecheck— cleannpx vitest run test/unit/selfhost-config-lint.test.ts test/unit/gittensory-config-lint-script.test.ts— 28/28config-lint.ts: 100% statements/branches/functions/linesnpm run docs:drift-check— cleanexperimentalCloses #5281