fix(config): stop documenting the retired blockedPaths key as a live feature#5304
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | b34d241 | Commit Preview URL Branch Preview URL |
Jul 12 2026, 01:58 PM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5304 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 474 474
Lines 40128 40128
Branches 14631 14631
=======================================
Hits 37871 37871
Misses 1582 1582
Partials 675 675
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - fixes requiredReview updated: 2026-07-12 13:46:32 UTC
🛑 Suggested Action - Manual Review
Review summary Nits — 7 non-blocking
CI checks failing
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
…feature blockedPaths was fully retired from the FocusManifest parser in #2974 (2026-07-04) -- it produces zero findings and is not enforceable under any gate.manifestPolicy mode. That retirement commit missed the two checked-in bootstrap templates (.gittensory.yml.example, config/examples/gittensory.full.yml), which kept documenting it with example values and false claims that it feeds guidance/becomes an enforceable blocker. This is very likely why all 3 live self-hosted repos still carry a dead blockedPaths: [] key today. Fixes the false claims in both templates (byte-synced, both edited identically), fixes the self-hosting docs page's self-contradicting paragraph, and extends config-templates.test.ts to also run lintManifestText (the only function with the retired-field check) so a retired field reintroduced into a shipped template fails CI automatically going forward -- the previous zero-warnings test used the lenient parser, which structurally cannot catch this class of bug. Also removes the dead "manifest_blocked_path" string from processors.ts's policyCodes Set (no producer has emitted that code since the retirement). Refs #5294
40b33de to
7458884
Compare
CI's ui:lint caught formatting the earlier commit's editor didn't apply. No content change, whitespace wrapping only.
Summary
blockedPathswas fully retired from the FocusManifest parser in fix(selfhost): make hard guardrails authoritative #2974 (2026-07-04) — zero findings, not enforceable under anygate.manifestPolicymode. That commit missed the two checked-in bootstrap templates, which kept documenting it with example values and false claims (feeds guidance, becomes an enforceable blocker). Very likely why all 3 live self-hosted repos still carry a deadblockedPaths: []key today.config-templates.test.tsto also runlintManifestText(the only function with the retired-field check) so a retired field reintroduced into a shipped template fails CI automatically — the previous zero-warnings test used the lenient parser, which structurally can't catch this."manifest_blocked_path"string fromprocessors.ts'spolicyCodesSet.Scope
.gittensory.yml.example,config/examples/gittensory.full.yml,docs.self-hosting-configuration.tsx,test/unit/config-templates.test.ts,src/queue/processors.ts,test/unit/queue-2.test.ts(stale comment).Validation
npm run typecheck— cleannpx vitest run test/unit/config-templates.test.ts— 19/19 (new lint-zero-warnings test included)npx vitest run test/unit/gate-check-policy.test.ts test/unit/focus-manifest.test.ts test/unit/predicted-gate.test.ts test/unit/local-branch.test.ts test/unit/mcp-predict-gate.test.ts— 880/880 (every test referencing the retired code, confirming theprocessors.tsSet edit is inert)npm run docs:drift-check— cleannpm run ui:typecheck— cleanNot in this PR
Stripping the live
blockedPaths: []key from the 3 production self-hosted configs is a separate, direct VPS operational step (no code/PR needed there) — tracked in #5294 alongside this PR.Closes #5294