Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions apps/gittensory-ui/src/routes/docs.github-app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,14 @@ GET /v1/installations/:id/repair`}
<h2>Checks</h2>
<p>
The gittensory app publishes its review as check runs.{" "}
<strong>Gittensory Orb Review Agent</strong> is the gate result;{" "}
<strong>Gittensory Context</strong> is the advisory companion. Both are controlled per repo
by <code>checkRunMode</code> (<code>off</code> / <code>enabled</code>), with{" "}
<code>checkRunDetailLevel</code> choosing <code>minimal</code>, <code>standard</code>, or{" "}
<code>deep</code> output.
<strong>Gittensory Orb Review Agent</strong> is the gate result, controlled by{" "}
<code>reviewCheckMode</code> (<code>required</code> / <code>visible</code> /{" "}
<code>disabled</code>). <strong>Gittensory Context</strong> is the separate advisory
companion, controlled by its own <code>checkRunMode</code> (<code>off</code> /{" "}
<code>enabled</code>) — these two switches are independent axes, not one setting for both
checks. <code>checkRunDetailLevel</code> (<code>minimal</code> / <code>standard</code>) only
affects <strong>Gittensory Context</strong>'s output depth; it has no effect on the Orb
Review Agent check.
</p>
<p>
<strong>Gittensory Context</strong> is advisory and should not be required in branch
Expand Down
11 changes: 6 additions & 5 deletions apps/gittensory-ui/src/routes/docs.how-reviews-work.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -295,11 +295,12 @@ function HowReviewsWork() {
</li>
</ul>
<p>
The check run can carry the same signals at adjustable depth: <code>checkRunMode</code> (
<code>off</code> / <code>enabled</code>) publishes the{" "}
<strong>Gittensory Orb Review Agent</strong> check, and <code>checkRunDetailLevel</code> (
<code>minimal</code> / <code>standard</code> / <code>deep</code>) sets how much the check
summary spells out.
The check run can carry the same signals at adjustable depth — but this is the{" "}
<strong>Gittensory Context</strong> check, not the Orb Review Agent gate check:{" "}
<code>checkRunMode</code> (<code>off</code> / <code>enabled</code>) publishes it, and{" "}
<code>checkRunDetailLevel</code> (<code>minimal</code> / <code>standard</code>) sets how
much the check summary spells out. <strong>Gittensory Orb Review Agent</strong> is published
separately, controlled by <code>reviewCheckMode</code> (see above).
</p>

<h2>Putting it together</h2>
Expand Down
7 changes: 4 additions & 3 deletions apps/gittensory-ui/src/routes/docs.tuning.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -472,9 +472,10 @@ function Tuning() {
<code>publicSignalLevel</code> — <code>minimal</code> / <code>standard</code> (default).
</li>
<li>
<code>checkRunMode</code> — check-run publishing: <code>off</code> (default) /{" "}
<code>enabled</code>. Pair with <code>checkRunDetailLevel</code> (<code>minimal</code>{" "}
(default) / <code>standard</code> / <code>deep</code>).
<code>checkRunMode</code> — publishes the <strong>Gittensory Context</strong> check (not
the <strong>Orb Review Agent</strong> gate check, which is <code>reviewCheckMode</code>):{" "}
<code>off</code> (default) / <code>enabled</code>. Pair with{" "}
<code>checkRunDetailLevel</code> (<code>minimal</code> (default) / <code>standard</code>).
</li>
<li>
<code>publicSurface</code> — <code>off</code> / <code>comment_and_label</code> (default) /{" "}
Expand Down
10 changes: 6 additions & 4 deletions src/review/repo-profile.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,12 @@ export type RepoProfileCommands = {
};

export type RepoProfileContributionWorkflow = {
/** Whether the review gate publishes a check at all, derived from `settings.reviewCheckMode` -- the actual
* runtime authority for check publication (#2852); `gateCheckMode`/`checkRunMode` are legacy fields kept
* only for API/back-compat display and no longer drive this decision. Reuses the EXISTING settings
* resolver rather than re-deriving gate presence from raw repo files. */
/** Whether the review gate (the "Gittensory Orb Review Agent" check) publishes a check at all, derived
* from `settings.reviewCheckMode` -- the actual runtime authority for that check's publication (#2852).
* `gateCheckMode` is a genuinely legacy, deprecated read-back field (#4618) kept only for API/back-compat
* display and no longer drives anything. `checkRunMode` is NOT legacy -- it's a live, independent field
* that governs the SEPARATE "Gittensory Context" check, unrelated to this one. Reuses the EXISTING
* settings resolver rather than re-deriving gate presence from raw repo files. */
gatePublishesCheck: boolean;
linkedIssuePolicy: "required" | "preferred" | "optional";
requireLinkedIssue: boolean;
Expand Down
5 changes: 5 additions & 0 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,11 @@ export type RepositorySettings = {
commentMode: "off" | "detected_contributors_only" | "all_prs";
publicAudienceMode: "oss_maintainer" | "gittensor_only";
publicSignalLevel: "minimal" | "standard";
/** Publishes the SEPARATE, always-advisory "Gittensory Context" check-run (#2691) -- entirely independent
* of {@link reviewCheckMode}, which governs the "Gittensory Orb Review Agent" gate check. Despite the
* similar name and shape, this is NOT a sibling/legacy-alias of reviewCheckMode; the two checks are
* different check-runs with different controlling fields (a mismatch already caused real doc drift --
* see the disambiguation in README's "Check-run and comment surfaces" section). */
checkRunMode: "off" | "enabled";
// #4620: "deep" removed -- it was never wired to any different behavior than "standard" (formatCheckRunOutput
// and buildCheckRunAnnotations in rules/advisory.ts both branch only on `=== "minimal"` vs not).
Expand Down
Loading