Skip to content

docs(settings): disclose that agentDryRun doesn't stop AI/LLM spend#5296

Merged
gittensory-orb[bot] merged 1 commit into
mainfrom
fix/agent-dry-run-spend-disclosure
Jul 12, 2026
Merged

docs(settings): disclose that agentDryRun doesn't stop AI/LLM spend#5296
gittensory-orb[bot] merged 1 commit into
mainfrom
fix/agent-dry-run-spend-disclosure

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • agentDryRun's doc comment, the maintainer-dashboard toggle hint, and both yml example files all implied a cost-free preview.
  • In reality every AI/LLM spend gate checks only agentPaused, never agentDryRun — dry-run still executes real, billed review calls and only suppresses the terminal GitHub write.
  • Fixes the copy at all three surfaces a maintainer actually reads. No behavior change (the spend-gate design is deliberate, #token-bleed-spend-gate).

Scope

Docs/copy only: src/types.ts, apps/gittensory-ui/.../maintainer-settings.tsx, .gittensory.yml.example, config/examples/gittensory.full.yml.

Validation

  • npm run typecheck — clean
  • npx vitest run test/unit/config-templates.test.ts — 18/18 passing (yml template sync intact)
  • npm run docs:drift-check — clean
  • npm run ui:typecheck / npm run ui:lint — clean (0 errors)

Safety

No logic change, no new surface, no secrets.

Closes #5286

agentDryRun's doc comment, dashboard hint, and yml example all implied
a cost-free preview. In reality every spend gate checks only
agentPaused -- dry-run still runs real AI/LLM review calls at real
provider cost, suppressing only the terminal GitHub write. This is a
deliberate design (#token-bleed-spend-gate); the fix is disclosure
only, no behavior change.

Refs #5286
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 46cc22b Commit Preview URL

Branch Preview URL
Jul 12 2026, 01:14 PM

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.36%. Comparing base (fb9fb20) to head (46cc22b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5296   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files         474      474           
  Lines       40124    40124           
  Branches    14629    14629           
=======================================
  Hits        37865    37865           
  Misses       1583     1583           
  Partials      676      676           
Flag Coverage Δ
shard-1 46.27% <ø> (-0.15%) ⬇️
shard-2 34.73% <ø> (+0.03%) ⬆️
shard-3 32.17% <ø> (+0.10%) ⬆️
shard-4 31.84% <ø> (-0.26%) ⬇️
shard-5 33.44% <ø> (-0.24%) ⬇️
shard-6 45.07% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/types.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb gittensory-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 12, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 12, 2026

Copy link
Copy Markdown

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

Review updated: 2026-07-12 13:21:59 UTC

4 files · 2 AI reviewers · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a pure documentation/copy correction across four surfaces (a JSDoc comment, two yml example files, and a UI hint string) to accurately disclose that agentDryRun still incurs AI/LLM spend since only agentPaused gates that cost, not agentDryRun. The diff is internally consistent, matches its stated intent, and correctly closes issue #5286. No logic is touched and CI is green across all checks.

Nits — 7 non-blocking
  • The three doc surfaces (types.ts, both yml examples, UI hint) now repeat the same explanation with slightly different wording — consider a single canonical phrasing to avoid future drift when the spend-gate design changes.
  • No test-path changes are expected for a docs-only PR, but confirm docs:drift-check (mentioned in the PR description) actually asserts yml-comment/types.ts sync so this class of doc/code copy divergence can't silently reappear.
  • Consider linking directly to the `#token-bleed-spend-gate` tag definition or a short design doc from the types.ts comment so future readers don't have to grep three files to find the actual gate logic.
  • In maintainer-settings.tsx:564, the shortened hint text is good for UI space but could also surface a tooltip/link to the fuller explanation for maintainers who want the 'why'.
  • nit: `src/types.ts:1092` hard-codes several implementation filenames in a public settings comment, which makes the docs more likely to drift during future refactors.
  • PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.
Signal Result Evidence
Code review ✅ No blockers 2 reviewers, synthesized
Linked issue ✅ Linked #5286
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 44 registered-repo PR(s), 36 merged, 476 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 44 PR(s), 476 issue(s).
Gate result ✅ Passing No configured blocker found.
Improvement ⚠️ ℹ️ None detected risk: low · value: none — No structural-improvement signals were detected for this PR. LLM value judgment: minor — The change fixes a real, previously misleading disclosure about billing behavior across three maintainer-facing surfaces, but it is a narrowly-scoped copy fix with no code or behavior impact.
Linked issue satisfaction

Addressed
The diff updates the doc comment in src/types.ts, the maintainer-settings.tsx toggle hint, and the yml example (plus the bonus .gittensory.yml.example) to explicitly state AI/LLM calls still execute and incur cost, matching all three required deliverables with no logic changes.

Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 44 PR(s), 476 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before / after /
/ mobile before / (mobile) after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@gittensory-orb gittensory-orb Bot merged commit 595855b into main Jul 12, 2026
20 checks passed
@gittensory-orb gittensory-orb Bot deleted the fix/agent-dry-run-spend-disclosure branch July 12, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disclose that agentDryRun does not stop AI/LLM spend

1 participant