Skip to content

ci(alerts): avoid app token setup for alert tests #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
May 10, 2026
+3 −1
Merged

ci(alerts): avoid app token setup for alert tests #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/control-plane.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:

- name: Resolve GitHub App token
id: app-token
if: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || github.event_name == 'issues' }}
if: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && inputs.mode != 'alert-test') || github.event_name == 'issues' }}
env:
AIO_FLEET_APP_ID: ${{ secrets.AIO_FLEET_APP_ID }}
AIO_FLEET_APP_INSTALLATION_ID: ${{ secrets.AIO_FLEET_APP_INSTALLATION_ID }}
Expand Down
2 changes: 2 additions & 0 deletions tests/test_control_plane_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,11 @@ def test_alert_test_mode_uses_alert_webhook_secret_only() -> None:
workflow = yaml.safe_load(WORKFLOW.read_text())
on_config = workflow.get("on", workflow.get(True))
mode = on_config["workflow_dispatch"]["inputs"]["mode"]
app_token = _step(workflow["jobs"]["control-plane"], "Resolve GitHub App token")
alert_test = _step(workflow["jobs"]["control-plane"], "Test alert webhook")

assert "alert-test" in mode["options"] # nosec B101
assert "inputs.mode != 'alert-test'" in app_token["if"] # nosec B101
assert ( # nosec B101
alert_test["if"]
== "${{ github.event_name == 'workflow_dispatch' && inputs.mode == 'alert-test' }}"
Expand Down
Loading