fix(security): harden central fleet checks#103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aio-fleet / requiredcontrol-check path so manifest-only app repos are enforced by the aggregate required check.What changed
validate-repoandverify-callersteps before app-controlled install/generator/pytest steps.integration_pytest_args..yml,.yaml,action.yml, andaction.yaml.Why
Validation
.venv/bin/python -m pytest -q->220 passedtrunk check --no-progress --color=false-> passedactionlint .github/workflows/control-plane.yml-> passedtofu -chdir=infra/github fmt -check-> passedtofu -chdir=infra/github init -backend=false -input=false && tofu -chdir=infra/github validate-> passed.github/workflows/pwn.yamlnow fails withcentral_check_rc=1Notes