Wire C# build verification into execution pipeline#20
Open
Conversation
verify_csharp_build() existed but was never called. Now assembly tasks automatically trigger dotnet build after completion — on failure, the task resets to PENDING with compiler errors injected as context feedback. - Decomposer injects csproj_path from project config into assembly task context - _run_csharp_build_verification() helper handles both internal and external paths - Config: execution.csharp_build_verify (default true) - 6 new tests covering success/failure/skip/config scenarios Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Self-review fix: when build verification resets an externally-claimed task to PENDING, clear the claim fields so any executor can pick it up immediately rather than waiting for stale claim recovery. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
Self-review defect found and fixed (28b034b): Defect: When build verification fails, the task is reset to PENDING but /\ were not cleared. An externally-claimed task would sit in a claimed-but-PENDING state until stale claim recovery kicked in (~1 hour). Fix: Added \ to the UPDATE statement in . Why the original was wrong: The reset path was modeled after internal task retries (which don't have claims), not external task retries. |
Reflects tests added in recent PRs: stale claims (4), C# build hook (6), and others merged since the count was last updated. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JMRussas
commented
Mar 12, 2026
Owner
Author
JMRussas
left a comment
There was a problem hiding this comment.
Core logic is correct. Note: build error feedback accumulates in context_json with no cap — after 5+ retries the context blob bloats. Consider limiting to last N entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_csharp_build()existed intask_lifecycle.pybut was never called — assembly tasks completed without build checkscsproj_pathfrom project config into assembly task context_run_csharp_build_verification()helper runs after task completion in bothexecute_task()andcomplete_task_external()pathsexecution.csharp_build_verify(defaulttrue)Test plan
python -m ruff check— cleantest_csharp_build_hook.py— all passpython -m pytest tests/ -m "not slow"— 785 passed, 0 failedGenerated by Claude Code · Claude Opus 4.6