Optimise triggers by using SQL variables #1
Conversation
|
|
||
| $variables = [" | ||
| DECLARE calculated_contact_id integer; | ||
| SET calculated_contact_id := (SELECT contact_id FROM civicrm_contribution WHERE id = NEW.contribution_id); |
There was a problem hiding this comment.
@monishdeb aren't SQL variables normally set to start with an @
There was a problem hiding this comment.
@seamuslee001 actually there are two types of variable declaration, the one which starts with @ is a user-defined loosely typed variable (by loosely means can be directly assigned with a value without declaring the type) and can be re-used in other Triggers/Procedure in a session and without @ is a local variable which is a valid in particular trigger and need to mention their type. For more detail please check here.
In this case as there are three CREATE/UPDATE/DELETE event trigger, so I thought its better to have a there respective local variable.
|
This seems ok but I need to r-run it if possible on test sites before being comfortable with it, I suspect it won't help that much but at least we are getting rid of one sub query |
No description provided.