fix: release path filter uses push range#94
Merged
tlarbals824 merged 1 commit intodevelopfrom May 5, 2026
Merged
Conversation
Use the push event before/after range so API client publishing is gated by the changes introduced by the main push, not by the current develop/main branch delta.\n\nConstraint: dorny/paths-filter defaults compared develop...main on release pushes, missing src changes already present in develop.\nRejected: Always publish API client | would publish even for docs-only releases.\nConfidence: high\nScope-risk: narrow\nDirective: Keep release path filtering anchored to push event SHAs for main push workflows.\nTested: git diff --check\nNot-tested: GitHub Actions runtime execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
release.yml의publish-api-client가 PR #93 머지 후 실행되지 않았습니다.원인은
check-source-changes단계에서dorny/paths-filter가 main push에 포함된 변경사항이 아니라, 현재 브랜치 상태 기준의develop...main차이를 비교했기 때문입니다.이 경우
develop에 이미 들어가 있던src/**변경은 감지되지 않아src == true가 되지 않았고, 결과적으로publish-api-clientjob이 skipped 되었습니다.수정 내용
paths-filter의 비교 기준을 명시적으로 main push 이벤트의 전후 커밋으로 변경했습니다.이제 release workflow는 브랜치 간 차이가 아니라, 실제로 main에 push된 변경 범위를 기준으로
src/**,build.gradle.kts,buildSrc/**변경 여부를 판단합니다.기대 효과
develop → mainrelease PR 머지 시 포함된src/**변경을 정상 감지합니다.publish-api-client가 실행됩니다.검증
git diff --check