Fix failing pytest tests #6
Conversation
This commit addresses several failing tests in the API application. The primary issue was an `AttributeError` in the patch tests for workspaces and shared services. The mock for `ResourceTemplateRepository.get_template_by_name_and_version` was incorrectly returning a resource object instead of a `ResourceTemplate` object, leading to a failure when the code attempted to access schema properties like `allOf`. This has been corrected by creating and using a `sample_resource_template` helper function in the tests. Additionally, a test in `test_resource_repository.py` was failing because it was not `await`ing an `async` function, which prevented an expected `ValidationError` from being raised. The test has been updated to be `async` and to correctly `await` the coroutine.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This change fixes several failing pytest tests. The errors were caused by an AttributeError due to incorrect mocking and a test that was not correctly awaiting an async function.
PR created automatically by Jules for task 5588496719340007556 started by @JC-wk