Skip to content

Issue with FNG-HCPB post-processing #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dodu94 merged 3 commits into from
Feb 19, 2026
Merged

Issue with FNG-HCPB post-processing #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92eb5f2
The mass factor is already included in the scale factor, so this was …
jude-moo Feb 10, 2026
205302f
trying change to make code compatible with pandas 3.0.0
jude-moo Feb 16, 2026
90a8927
trying change to make code compatible with pandas 3.0.0, manually add…
jude-moo Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/jade/post/manipulate_tally.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,22 @@ def condense_groups(
"""
tally["abs err"] = tally["Error"] * tally["Value"]
# this divides the entries in coarse energy bins

tally["coarse_bin"] = pd.cut(tally[group_column], bins=bins, right=False)
tally = tally.drop(columns=[group_column])
tally[group_column] = tally["coarse_bin"].apply(
lambda x: f"{x.left:g} - {x.right:g}"
lambda x: f"{x.left:g} - {x.right:g}" if pd.notna(x) else np.nan
)
'''
labels = [f"{bins[i]:g} - {bins[i+1]:g}" for i in range(len(bins) - 1)]

tally[group_column] = pd.cut(
tally[group_column],
bins=bins,
right=False,
labels=labels,
)
'''
del tally["coarse_bin"]
grouped = tally.groupby(group_column, observed=False).agg(
{"Value": "sum", "abs err": lambda x: math.sqrt((x**2).sum())}
Expand Down
2 changes: 0 additions & 2 deletions src/jade/resources/default_cfg/benchmarks_pp/raw/openmc/FNG-HCPB.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,14 +126,12 @@ Reaction rate:
Tritium activity:
concat_option: no_action
84:
- [mass, {}]
- [scale, {'factor': 2.57042574E+07}]
- [replace, {'column': 'Cells', 'values': *depth_h3}]

Tritium activity Pellet:
concat_option: no_action
84:
- [mass, {}]
- [scale, {'factor': 2.57042574E+07}]
- [add_column_with_dict, {'ref_column': 'Cells', 'values': *depth_h3d, new_columns: [ 'Distance','Pellet']}]
- [replace, {'column': 'Cells', 'values': *depth_h3}]