Skip to content

[00259] Remove unused insert_with_id from ViewTree #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rorychatt merged 1 commit into from
Apr 16, 2026
Merged

[00259] Remove unused insert_with_id from ViewTree #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions rusty/src/core/view_tree.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,28 +59,6 @@ impl ViewTree {
child_id
}

/// Insert a child view with a specific ViewId (for stable keying).
pub fn insert_with_id(
&mut self,
parent_id: ViewId,
child_id: ViewId,
view: Arc<dyn View>,
) -> ViewId {
let child_node = ViewNode {
view_id: child_id,
view,
parent: Some(parent_id),
children: Vec::new(),
};
self.nodes.insert(child_id, child_node);
if let Some(parent) = self.nodes.get_mut(&parent_id) {
if !parent.children.contains(&child_id) {
parent.children.push(child_id);
}
}
child_id
}

/// Remove a node and all its descendants from the tree.
/// Returns the list of removed ViewIds (for HookStore cleanup).
pub fn remove(&mut self, view_id: ViewId) -> Vec<ViewId> {
Expand Down
Loading