Honor .gitattributes linguist overrides; drop .sln phantom components#17
Merged
Merged
Conversation
Two report-credibility/robustness fixes from the review backlog. 128 tests (+2 new); no existing fixture detection changed. - .gitattributes support: FileSystemScanner reads each directory's .gitattributes and honors linguist-vendored / linguist-generated (excluded from language stats and components) and linguist-documentation (doc-flagged), reusing the gitignore glob engine. Repo-portable, mirrors github-linguist, and resolves the Apex/LaTeX .cls false positive (those files live under a tests/data/** path the repo marks vendored). - Phantom component drop: ComponentDetector removes any non-root workspace-root component that owns no languages and no parsed manifests (a bare .sln/.slnx build dir is an artifact of a real root, not a component). Also closes a latent hash-pollution path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two report-credibility/robustness fixes from the review backlog (both hash-impact: none, but improve language-stat accuracy and component cleanliness). 128 tests pass (+2 new); no existing fixture detection changed.
.gitattributeslinguist overrides —FileSystemScannernow reads each directory's.gitattributesand honorslinguist-vendored/-generated(excluded from language stats & components) andlinguist-documentation(doc-flagged), reusing the gitignore glob engine. Repo-portable, mirrors github-linguist, and resolves the Apex/LaTeX.clsfalse positive (those files live under atests/data/**path the repo marks vendored)..slnphantom-component drop —ComponentDetectorremoves any non-rootIsWorkspaceRootcomponent that owns no languages and no parsed manifests (a bare.sln/.slnxbuild dir is an artifact of a real root, not a component). Also closes a latent hash-pollution path.Remaining backlog items were assessed and intentionally left (not worth it for the hash / risky / niche): C2 vendored lockfiles, C9 maturin, C10 import-scan, L4-rest Emscripten glue, L6 docs-scoping, example-demo. Tracked in
src/.review/_PLAN.md.