Detect bun test via package.json scripts matcher#13
Merged
Conversation
Adds a scriptsRegex match facet to the rule engine. package.json scripts are now parsed (NpmParser -> ParsedManifest.Scripts -> ComponentContext.Scripts) and matched against RuleDef ScriptsRegex. New 'bun test' testing detector keys off scripts.test containing 'bun test'. Closes the deferral from the testing-detectors PR; the facet is reusable for any tool invoked only via a script. rulesLoaded 759->760.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the deferred follow-up from the testing-detectors PR (#5).
New engine facet:
scriptsRegexonMatchSpec. package.jsonscriptsvalues are now parsed (NpmParser->ParsedManifest.Scripts->ComponentContext.Scripts) and matched as a strong signal inRuleEngine.New detector:
bun-test(category testing) keys offscripts.testcontainingbun test— bun's runner has no dependency or config-file marker, so this was previously undetectable.Reusable for any tool invoked only via a script. Tests: 105/105 (3 new). Snapshots: rulesLoaded 759->760.