A collection of small contributions#2
Open
larsks wants to merge 9 commits intoIsaiahStapleton:mainfrom
Open
Conversation
Level 1 headings should be followed by level 2 headings, not level 3 headings.
Mostly adding literal quotes where appropriate, with a couple of minor spelling changes.
- We don't need a shell to run `git clone` - Container names should be descriptive of what the container does - Always use fully qualified image names, even for images coming from docker hub
Using a configmap generator allows us to store the file content as an actual YAML file, which allows for proper syntax checking in your editor or your CI scripts.
Use port names rather than numbers in service and deployment.
The `run-llm-load-test` directory contained nothing but the `llm-load-test` directory. Move this to the top level, and remove the `run-llm-load-test` directory.
From a branding perspective, we should always prefer `Containerfile` over `Dockerfile`.
This will prevent unnecessarily re-installing dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a number of small changes to the project. Feel free to pick and choose if you disagree with some of the changes.