Skip to content

Fix: Ensure NORMAL env always uses vanilla noise overworld generation #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d0lo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Ensure NORMAL env always uses vanilla noise overworld generation #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Multiworld-Common/src/main/java/me/isaiah/multiworld/ICreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,18 @@ public default Text colored_literal_(String txt, Formatting color) {
default ChunkGenerator get_chunk_gen(MinecraftServer mc, String env) {
ChunkGenerator gen = null;
if (env.contains("NORMAL") || env.contains("DEFAULT")) {
gen = mc.getWorld(World.OVERWORLD).getChunkManager().getChunkGenerator(); // .withSeed(seed);
var overworldGen = mc.getOverworld().getChunkManager().getChunkGenerator();
if (overworldGen instanceof net.minecraft.world.gen.chunk.FlatChunkGenerator) {
long seed = mc.getOverworld().getSeed();
var rm = mc.getRegistryManager();
var biomes = rm.get(net.minecraft.registry.RegistryKeys.BIOME);
var structs = rm.get(net.minecraft.registry.RegistryKeys.STRUCTURE_SET);
var noises = rm.get(net.minecraft.registry.RegistryKeys.NOISE_PARAMETERS);
var settings = rm.get(net.minecraft.registry.RegistryKeys.CHUNK_GENERATOR_SETTINGS).getOrThrow(net.minecraft.world.gen.chunk.ChunkGeneratorSettings.OVERWORLD);
var source = net.minecraft.world.biome.source.MultiNoiseBiomeSource.Preset.OVERWORLD.getBiomeSource(biomes, seed);
return new net.minecraft.world.gen.chunk.NoiseChunkGenerator(structs, noises, source, seed, () -> settings);
}
return overworldGen;
}

if (env.contains("NETHER")) {
Expand Down
Loading