SL-355: add Capture option to 3D Secure failure behavior setting#317
SL-355: add Capture option to 3D Secure failure behavior setting#317GytisZum wants to merge 2 commits intoSL-353/fields-settings-licencefrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the payment module by providing merchants with more granular control over how transactions are handled when 3D Secure authentication fails. Previously, the only explicit option was to cancel the order. With this change, a new "Capture" option is introduced, allowing the system to attempt to capture the payment even without a liability shift, providing greater flexibility in payment processing workflows. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a 'Capture' option for the 3D Secure failure behavior setting. The changes are implemented across the backend and frontend, including new configuration options, translation strings, and UI elements. The core logic in the notify and return controllers has been updated to handle this new behavior. My main feedback is regarding code duplication between these two controllers, which could be refactored to improve maintainability.
| if (!$assertResponseBody->getLiability()->getLiabilityShift() && | ||
| in_array($order->payment, SaferPayConfig::SUPPORTED_3DS_PAYMENT_METHODS) && | ||
| (int) Configuration::get(SaferPayConfig::PAYMENT_BEHAVIOR_WITHOUT_3D) === SaferPayConfig::PAYMENT_BEHAVIOR_WITHOUT_3D_CANCEL | ||
| in_array($order->payment, SaferPayConfig::SUPPORTED_3DS_PAYMENT_METHODS) | ||
| ) { | ||
| /** @var SaferPayOrderStatusService $orderStatusService */ | ||
| $orderStatusService = $this->module->getService(SaferPayOrderStatusService::class); | ||
| $orderStatusService->cancel($order); | ||
|
|
||
| $logger->debug(sprintf('%s - Liability shift is false', self::FILE_NAME), [ | ||
| 'context' => [ | ||
| 'id_order' => $order->id, | ||
| ], | ||
| ]); | ||
|
|
||
| $logger->debug(sprintf('%s - liability shift is false', self::FILE_NAME), [ | ||
| 'context' => [ | ||
| 'id_order' => $order->id, | ||
| ], | ||
| ]); | ||
|
|
||
| die($this->module->l('Liability shift is false', self::FILE_NAME)); | ||
| if ($paymentBehaviorWithout3D === SaferPayConfig::PAYMENT_BEHAVIOR_WITHOUT_3D_CANCEL) { | ||
| $orderStatusService->cancel($order); | ||
|
|
||
| $logger->debug(sprintf('%s - Liability shift is false, canceling order', self::FILE_NAME), [ | ||
| 'context' => [ | ||
| 'id_order' => $order->id, | ||
| ], | ||
| ]); | ||
|
|
||
| die($this->module->l('Liability shift is false', self::FILE_NAME)); | ||
| } elseif ($paymentBehaviorWithout3D === SaferPayConfig::PAYMENT_BEHAVIOR_WITHOUT_3D_CAPTURE | ||
| && SaferPayConfig::supportsOrderCapture($order->payment) | ||
| && $transactionStatus !== TransactionStatus::CAPTURED | ||
| ) { | ||
| $orderStatusService->capture($order); | ||
|
|
||
| $logger->debug(sprintf('%s - Liability shift is false, capturing order', self::FILE_NAME), [ | ||
| 'context' => [ | ||
| 'id_order' => $order->id, | ||
| ], | ||
| ]); | ||
| } | ||
| } |
There was a problem hiding this comment.
This block of logic for handling failed liability shift is nearly identical to the code in controllers/front/return.php on lines 334-350. This code duplication can lead to maintenance issues, where a change in one place might be forgotten in the other.
To improve maintainability, I recommend extracting this logic into a shared method. Since both SaferPayOfficialNotifyModuleFrontController and SaferPayOfficialReturnModuleFrontController extend AbstractSaferPayController, you could add a protected method to the base class to encapsulate this shared logic.
This refactoring would also be a good opportunity to improve the readability of the long elseif condition by breaking it down into smaller, well-named boolean variables.
1 participant
Self-Checks
JIRA task link
Summary
QA Checklist Labels
QA Checklist
Additional Context
Frontend Changes