-
Notifications
You must be signed in to change notification settings - Fork 511
feat: native builtin data vs th builtin data benchmark #7562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| module Main (main) where | ||
|
|
||
| import Data.Text qualified as Text | ||
| import LinearVesting.TestOptimized (validatorOptimizedCodeFullyApplied) | ||
| import PlutusTx.Test (displayEvalResult, evaluateCompiledCode) | ||
|
|
||
| main :: IO () | ||
| main = do | ||
| putStrLn "" | ||
| putStrLn $ | ||
| Text.unpack $ | ||
| displayEvalResult $ | ||
| evaluateCompiledCode validatorOptimizedCodeFullyApplied |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
plutus-benchmark/linear-vesting/src/LinearVesting/TestOptimized.hs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| {-# LANGUAGE NoImplicitPrelude #-} | ||
|
|
||
| module LinearVesting.TestOptimized where | ||
|
|
||
| import LinearVesting.Test (testScriptContext) | ||
| import LinearVesting.ValidatorOptimized (validatorOptimizedCode) | ||
| import PlutusTx | ||
| import PlutusTx.Prelude | ||
|
|
||
| validatorOptimizedCodeFullyApplied :: CompiledCode BuiltinUnit | ||
| validatorOptimizedCodeFullyApplied = | ||
| validatorOptimizedCode `unsafeApplyCode` liftCodeDef (toBuiltinData testScriptContext) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did an experiment and results demonstate that multiway-if compiled by the plugin is actually better than hand-rolled lazy ifthenelse pattern you employ here:
#7578
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I guess similar could be achieved with
ifThenElseLazy predicate ~a ~b = BI.ifThenElse predicate a bright? And if the branches don't contain an error and the terms are small (ie. for&&which has onlyTrueandFalseas branches, then we would want to useBI.ifThenElsebecause multiway if isn't smart enough to know whether it can be safely optimized to strict (and whether it should based on the terms in the branches).I'll update the implementation to use multiway if, I'm sure it could be further optimized, but I just did a rough translated to BuiltinData and didn't put much effort into optimization and it is already optimized to around 35% of the budget of the TH Data version.