Skip to content

Fixed peerselection test failure#5342

Open
coot wants to merge 6 commits intomainfrom
coot/known-peers-failure
Open

Fixed peerselection test failure#5342
coot wants to merge 6 commits intomainfrom
coot/known-peers-failure

Conversation

@coot
Copy link
Collaborator

@coot coot commented Mar 19, 2026 •
edited
Loading

Description

This PR fixes know target (from below). Since #5353, the governor can forget known peers, so the property need to account for it.

I noticed that our prologue file is outdated:

  • Updated prologue file

Then some signal API / output improvements:

  • signal: ppEvents - pretty print events
  • signal: signalProperty' - more concise counterexample output

Some code style changes:

  • peer-selection: code style

And the main patch (no changes in production code, except for a newly added
tracer):

  • peer-selection: fixed know target (from below) property
  • Added changelog

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot coot requested a review from a team as a code owner March 19, 2026 12:33
@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Mar 19, 2026
@coot coot self-assigned this Mar 19, 2026
@coot coot added outbound-governor Issues / PRs related to outbound-governor test-failure a test failure labels Mar 19, 2026
coot added 2 commits March 19, 2026 14:22
@coot
peer-selection: fixed know target (from below) property
defbe44 
Since #5253, peer selection can forget know peers.  This patch relaxes
the property.  Peer selection now logs the set of forgotten peers via
`TraceForgottenPeers`, which is used by the property.
@coot
Added changelog
32e5650
@coot coot force-pushed the coot/known-peers-failure branch from edf2091 to 32e5650 Compare March 19, 2026 13:32
karknu
karknu approved these changes Mar 19, 2026
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot enabled auto-merge March 19, 2026 15:06
@coot coot added this pull request to the merge queue Mar 19, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karknu karknu karknu approved these changes

Assignees

@coot coot

Labels

outbound-governor Issues / PRs related to outbound-governor test-failure a test failure

Projects

Ouroboros Network
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coot @karknu