Conversation
dcoutts
left a comment
dcoutts
left a comment
There was a problem hiding this comment.
This looks like a great start. Some comments below.
I think the next thing to try will be to use the cardano-api and try this with a test pipe consumer that just spits blocks out to stdout or something.
| import Ouroboros.Network.Protocol.ChainSync.Type | ||
| import Pipes | ||
|
|
||
| data ChainSyncResponse header point tip |
There was a problem hiding this comment.
Suggest renaming header everywhere to block. This will be intended to be used with blocks. With the node-to-client protocol, the chain sync provides blocks (whereas for the node-to-node it's used at type header).
| | IntersectFound point tip | ||
| | IntersectNotFound tip |
There was a problem hiding this comment.
This looks like a good start but I think where we want to go next is to not include the intersect finding in the pipe event stream, but to do all the intersection finding first and then yield the pipe producer (if the intersection finding is successful) for streaming the blocks.
So in the end we want just the roll forwards and roll backwards as pipe events.
And later we might want to rename it something like:
data BlockOrRollback block = NextBlock block | Rollback Point
| -> [point] | ||
| -> Producer (ChainSyncResponse header point tip) m dstate | ||
| chainSyncClientProducer driver known = | ||
| snd <$> runPeerWithDriver driver peer |
There was a problem hiding this comment.
I have to admit, I'm struggling to understand if this can plausibly work in the way we want it to.
I would have thought that runPeerWithDriver will run the peer to the end and not produce anything until it is done, which would not match what we want. My intuition is we'd need to break up runPeerWithDriver and integrate it into this function (fortunately it's not long).
But on the other hand, what you have has the right type. So I'm confused :-)
We might need to just try it out.
| (ChainSyncResponse header point tip) | ||
| m | ||
| (ClientStIdle header point tip (Producer (ChainSyncResponse header point tip) m) ()) | ||
| runPeer = |
There was a problem hiding this comment.
Oh I see, this is the initial intersection finding phase, before going into the main streaming phase. A little renaming would make this clearer.
2 participants
Description
reasonably detailed description of the pull request
Checklist
Quality
Maintenance
ouroboros-networkproject.