Trace transaction replies in txSubmissionOutbound after transactions are sent#1863
Draft
Trace transaction replies in txSubmissionOutbound after transactions are sent#1863
Conversation
ee54f98 to
a5cb1f8
Compare
mrBliss
reviewed
Mar 27, 2020
| -- Trace the transactions to be sent in the response. | ||
| traceWith tracer (TraceTxSubmissionOutboundSendMsgReplyTxs txs) | ||
| -- Trace the transactions to be sent in the response. | ||
| traceTxsSent = traceWith tracer (TraceTxSubmissionOutboundSendMsgReplyTxs txs) |
Contributor
There was a problem hiding this comment.
This requires a comment (here or near L195) saying that tracing itself will be executed after sending the reply.
Contributor
Author
@mrBliss: Do you feel the same way about the approach in the first commit? |
a5cb1f8 to
8fad020
Compare
8fad020 to
fd05404
Compare
32719f7 to
05436f9
Compare
05436f9 to
f3e301e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in #1688 I was mistakenly tracing
TraceTxSubmissionOutboundSendMsgReplyTxsevents before the transactions had been successfully sent.