Modify mkOpenState in ImmutableDB and VolatileDB#1917
Merged
Conversation
jasagredo
requested review from
bladyjoker,
dnadales,
fraser-iohk,
geo2a and
nfrisby
as code owners
jasagredo
force-pushed
the
js/forkers-again
branch
from
d9ffae7 to
922925e
Compare
jasagredo
force-pushed
the
js/mkOpenState
branch
from
278d565 to
effde21
Compare
nfrisby
force-pushed
the
js/forkers-again
branch
3 times, most recently
from
1ee95b8 to
8db9fa4
Compare
jasagredo
force-pushed
the
js/mkOpenState
branch
2 times, most recently
from
8bf89e9 to
28e580d
Compare
nfrisby
reviewed
Mar 30, 2026
|
|
||
| -- | Create the internal open state for the given chunk. | ||
| -- | ||
| -- TODO: mkOpenState does not need to run in WithTempRegistry. |
Contributor
There was a problem hiding this comment.
For reviewers: turns out this TODO was wrong
jasagredo
force-pushed
the
js/mkOpenState
branch
from
28e580d to
ff07c98
Compare
geo2a
approved these changes
Apr 2, 2026
nfrisby
approved these changes
Apr 2, 2026
Contributor
nfrisby
left a comment
nfrisby
left a comment
There was a problem hiding this comment.
LGTM, nice comments.
Follow-up question: is WithTempRegistry preferable to eg bracket for the repeated uses of mkOpenState? Sounds plausible, I just haven't thought it through at all.
Contributor
Author
|
We would need to do a bracket that doesn't deallocate the resource if it ends up in the TVar. Which I think is precisely what temp registries do so maybe it is not worth the complexity |
jasagredo
force-pushed
the
js/mkOpenState
branch
from
ff07c98 to
a4908cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.