Fix chunksBetween, which was always either empty or singleton#1872
Fix chunksBetween, which was always either empty or singleton#1872vreuter wants to merge 3 commits intoIntersectMBO:mainfrom
chunksBetween, which was always either empty or singleton#1872Conversation
vreuter
requested review from
bladyjoker,
dnadales,
fraser-iohk,
geo2a,
jasagredo and
nfrisby
as code owners
vreuter
changed the title
chunksBetween, which was always either empty or singleton
dnadales
left a comment
dnadales
left a comment
There was a problem hiding this comment.
Nice catch! Thank you for submitting the patch and for adding the tests!
|
@vreuter, the branch has some conflicts that need to be resolved. Do you want to do it, or should I clone your fork and do it myself. I have no problem doing it, but I wanted to check with you before cloning your fork 👍 |
vreuter
force-pushed
the
vince_erin/fix-chunksBetween
branch
from
451031c to
5750908
Compare
|
Hey thanks for checking @dnadales , I went ahead and resolved the conflicts now. |
| <!-- | ||
| ### Patch | ||
|
|
||
| - A bullet item for the Patch category. |
There was a problem hiding this comment.
Could you add a bullet explaining the patch change? See the other changelog entries for inspiration.
There was a problem hiding this comment.
Yes, I've updated the entry here 7213be4
…6d53 fix description of main subject of Immutable DB chunks tests modules
explain the change that is occurring
vreuter
force-pushed
the
vince_erin/fix-chunksBetween
branch
from
5750908 to
7213be4
Compare
|
OK @dnadales , I've described the change with a bulleted item in the |
|
Thank you @vreuter! |
Copied from #1872. This was necessary since all the commits need to be signed. Supersedes: #1872 Original authors: [vreuter](https://github.com/vreuter) and [ErinvanderVeen](https://github.com/ErinvanderVeen) Co-authored-by: Erin van der Veen <erin.vanderveen@tweag.io> Co-authored-by: Vince Reuter <vince.reuter@tweag.io>
|
Merged here #1923 |
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Consensus Team Backlog
3 participants
This change fixes a bug in the
chunksBetweenfunction in theOuroboros.Consensus.Storage.ImmutableDB.Chunks.Internal, whereby the result was always either empty (if the bounds of the range were unequal) or a single-item list (if the bounds were equal).