Skip to content

New criterion for transitioning to CaughtUp#1669

Merged
agustinmista merged 7 commits intoperas-stagingfrom
peras/enrich-caughtup-criterion
Oct 14, 2025
Merged

New criterion for transitioning to CaughtUp#1669
agustinmista merged 7 commits intoperas-stagingfrom
peras/enrich-caughtup-criterion

Conversation

@agustinmista
Copy link
Copy Markdown
Contributor

@agustinmista agustinmista commented Sep 8, 2025

@agustinmista agustinmista self-assigned this Sep 8, 2025
@agustinmista agustinmista force-pushed the peras/enrich-caughtup-criterion branch from 9c38ca6 to 9074a3c Compare September 15, 2025 12:04
@agustinmista agustinmista force-pushed the peras/enrich-caughtup-criterion branch 6 times, most recently from 8dc9126 to 0d1a363 Compare October 3, 2025 12:16
@agustinmista agustinmista linked an issue Oct 3, 2025 that may be closed by this pull request
GSM: new criterion for transitioning to CaughtUp: we received all certificates tweag/cardano-peras#66
Open
@agustinmista agustinmista force-pushed the peras/enrich-caughtup-criterion branch 8 times, most recently from 615c54e to 0d4ddb2 Compare October 8, 2025 10:28
@agustinmista agustinmista requested a review from amesgen October 8, 2025 11:30
amesgen
amesgen reviewed Oct 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread ...us/src/ouroboros-consensus/Ouroboros/Consensus/MiniProtocol/ObjectDiffusion/Inbound/State.hs Outdated
Comment thread ...oros-consensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/NodeKernel.hs Outdated
Comment thread ouroboros-consensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/Node/GSM.hs
Comment thread ...onsensus/src/ouroboros-consensus/Ouroboros/Consensus/MiniProtocol/ObjectDiffusion/Inbound.hs
Comment thread ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Tests/LoE/CaughtUp.hs
Comment thread ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/GSM.hs Outdated
@agustinmista agustinmista force-pushed the peras/enrich-caughtup-criterion branch 2 times, most recently from 751b517 to 7f85152 Compare October 8, 2025 19:12
agustinmista
agustinmista commented Oct 8, 2025
View reviewed changes
Comment thread ...oros-consensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/NodeKernel.hs Outdated
Comment thread ...oros-consensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/NodeKernel.hs Outdated
@agustinmista agustinmista force-pushed the peras/enrich-caughtup-criterion branch 2 times, most recently from b698718 to 22dabda Compare October 9, 2025 12:52
@amesgen amesgen mentioned this pull request Oct 9, 2025
Open
@agustinmista agustinmista force-pushed the peras/enrich-caughtup-criterion branch from 6b0ac0c to 722043c Compare October 9, 2025 15:26
@agustinmista agustinmista changed the base branch from peras-staging to main October 10, 2025 08:19
@agustinmista agustinmista changed the base branch from main to peras-staging October 10, 2025 08:19
@agustinmista agustinmista mentioned this pull request Oct 10, 2025
Merged
@agustinmista agustinmista force-pushed the peras/enrich-caughtup-criterion branch from 722043c to b8b7323 Compare October 10, 2025 09:15
@agustinmista agustinmista changed the title [WIP] New criterion for transitioning to CaughtUp New criterion for transitioning to CaughtUp Oct 10, 2025
@agustinmista agustinmista requested a review from amesgen October 10, 2025 09:22
amesgen
amesgen approved these changes Oct 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments

Comment thread ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Util/Orphans.hs
Comment thread ...oros-consensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/NodeKernel.hs Outdated
Comment thread ...onsensus/src/ouroboros-consensus/Ouroboros/Consensus/MiniProtocol/ObjectDiffusion/Inbound.hs
Comment thread ...oros-consensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/NodeKernel.hs Outdated
Comment thread ...us/src/ouroboros-consensus/Ouroboros/Consensus/MiniProtocol/ObjectDiffusion/Inbound/State.hs
@agustinmista agustinmista force-pushed the peras/enrich-caughtup-criterion branch 8 times, most recently from a48885d to 9bef992 Compare October 13, 2025 18:02
@agustinmista agustinmista force-pushed the peras/enrich-caughtup-criterion branch from 9bef992 to 776cd70 Compare October 13, 2025 18:40
@agustinmista agustinmista changed the base branch from peras-staging to main October 14, 2025 09:30
@agustinmista agustinmista changed the base branch from main to peras-staging October 14, 2025 09:30
amesgen
amesgen suggested changes Oct 14, 2025
View reviewed changes
Comment thread ...sensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/Node/GSM/PeerState.hs Outdated
@agustinmista agustinmista force-pushed the peras/enrich-caughtup-criterion branch from 776cd70 to 4e3115c Compare October 14, 2025 10:20
@agustinmista agustinmista merged commit 4e3115c into peras-staging Oct 14, 2025
12 checks passed
@agustinmista agustinmista deleted the peras/enrich-caughtup-criterion branch October 14, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfrisby nfrisby Awaiting requested review from nfrisby nfrisby will be requested when the pull request is marked ready for review nfrisby is a code owner

@jasagredo jasagredo Awaiting requested review from jasagredo jasagredo will be requested when the pull request is marked ready for review jasagredo is a code owner

@fraser-iohk fraser-iohk Awaiting requested review from fraser-iohk fraser-iohk will be requested when the pull request is marked ready for review fraser-iohk is a code owner

@dnadales dnadales Awaiting requested review from dnadales dnadales will be requested when the pull request is marked ready for review dnadales is a code owner

@geo2a geo2a Awaiting requested review from geo2a geo2a will be requested when the pull request is marked ready for review geo2a is a code owner

@bladyjoker bladyjoker Awaiting requested review from bladyjoker bladyjoker will be requested when the pull request is marked ready for review bladyjoker is a code owner

1 more reviewer

@amesgen amesgen amesgen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@agustinmista agustinmista

Labels

peras

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GSM: new criterion for transitioning to CaughtUp: we received all certificates

2 participants

@agustinmista @amesgen