ScheduledMerges: also test nested unions and arbitrary configs#814
Merged
ScheduledMerges: also test nested unions and arbitrary configs#814
Conversation
mheinzel
requested review from
dcoutts,
jorisdral,
recursion-ninja and
wenkokke
as code owners
mheinzel
force-pushed
the
mheinzel/prototype-tests-nested-union
branch
from
458fbf9 to
dabce7d
Compare
mheinzel
commented
Feb 16, 2026
mheinzel
force-pushed
the
mheinzel/prototype-tests-nested-union
branch
from
dabce7d to
182cd28
Compare
Collaborator
Author
|
Small change: I used newtypes for test inputs now, making their |
mheinzel
force-pushed
the
mheinzel/prototype-tests-nested-union
branch
2 times, most recently
from
0fb5b34 to
83f94db
Compare
This was referenced Mar 3, 2026
mheinzel
force-pushed
the
mheinzel/prototype-tests-nested-union
branch
from
83f94db to
9e43f0e
Compare
jorisdral
approved these changes
Mar 10, 2026
Collaborator
jorisdral
left a comment
jorisdral
left a comment
There was a problem hiding this comment.
Looks good to me! Good that we are improving the prototype tests 😄. I've left some comments but they shouldn't be blockers for this PR.
mheinzel
force-pushed
the
mheinzel/prototype-tests-nested-union
branch
from
9e43f0e to
b7bc5c2
Compare
jorisdral
approved these changes
Mar 24, 2026
| bufferSize :: Buffer -> Int | ||
| bufferSize = Map.size | ||
| -- | Flush a write buffer. In the real implementation, this involves IO. | ||
| -- Note that we should not never flush an empty write buffer. |
Collaborator
There was a problem hiding this comment.
Suggested change
| -- Note that we should not never flush an empty write buffer. | |
| -- Note that we should not ever flush an empty write buffer. |
Collaborator
There was a problem hiding this comment.
so we should always flush empty write buffers? 😜
Collaborator
Author
There was a problem hiding this comment.
Oops, I will fix that as part of the next PR.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We had already noted that testing nested unions (unions of tables that are themselves result of a union) would be a good idea. Also, after making some LSM parameters configurable in #716, it seems sensible to test more than just the default values.
As a preparation for further changes to the prototype, this PR addresses these points and makes small improvements to the invariants and properties we assert.