Lift TotalPeriodsKES to the type level in KESAlgorithm#637
Open
dancewithheart wants to merge 1 commit intoIntersectMBO:masterfrom
Open
Lift TotalPeriodsKES to the type level in KESAlgorithm#637dancewithheart wants to merge 1 commit intoIntersectMBO:masterfrom
dancewithheart wants to merge 1 commit intoIntersectMBO:masterfrom
Conversation
969b675 to
5ffb28f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #364
This PR lifts the total number of supported KES periods to the type level by
adding:
to
KESAlgorithm.This is a small API change for downstream
KESAlgorithminstances.Changes
TotalPeriodsKESas an associated type ofKESAlgorithmKnownNat (TotalPeriodsKES v)in theKESAlgorithmsuperclass contexttotalPeriodsKESa default term-level reflection ofTotalPeriodsKESTotalPeriodsKESat the type leveltotalPeriodsKESagrees withTotalPeriodsKESChecklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)