Open
Conversation
perturbing
commented
Mar 10, 2026
cardano-crypto-class/src/Cardano/Crypto/EllipticCurve/BLS12_381/Internal.hs
Show resolved
Hide resolved
7813782 to
9f394d8
Compare
9f394d8 to
e9d3d22
Compare
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes five things,
It adds a termination null pointer to the
AffineArrayPtrconstruction inwithAffineBlockArrayPtr. This aligns now with howwithPointArrayandwithScalarArraydo it. Note that even though theblstfunctions rely on the number of points passed as an argument, it is good to add this, as it is good practice.It fixed the
memcmpffi import, which was incorrectly usingCSize(unsigned int). Note that the return value ofmemcmpis a signed integer here. Since we used this function only inWhere the sign did not matter, it did not cause problems.
Use
CBoolinstead ofBoolin the FFI callsSerialization of PoP bytes should reject the zero point in the group (point at infinity)
Add the PoP Cipher suite as per the IETF draft (plus a comment on usage).
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)