gRPC: add tip timestamp to ChainPoint response#1134
Open
carbolymer wants to merge 1 commit intomasterfrom
Open
gRPC: add tip timestamp to ChainPoint response#1134carbolymer wants to merge 1 commit intomasterfrom
carbolymer wants to merge 1 commit intomasterfrom
Conversation
d65f369 to
12b6502
Compare
12b6502 to
ca2340d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the previously-unpopulated timestamp field in gRPC ChainPoint responses by computing tip time from SystemStart + EraHistory, and updates the encoding/decoding utilities and tests accordingly.
Changes:
- Populate
ChainPoint.timestampinreadParams/readUtxosby queryingSystemStartandEraHistoryand converting the tip slot to POSIX milliseconds. - Extend
mkChainPointMsgto accept a timestamp and add a corresponding decoder (utxoRpcChainPointMsgToChainPoint). - Add a Hedgehog roundtrip property for
ChainPointincluding the timestamp field; add requiredtimedependency.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cardano-rpc/src/Cardano/Rpc/Server/Internal/UtxoRpc/Query.hs | Queries SystemStart/EraHistory, computes tip timestamp, passes it into mkChainPointMsg. |
| cardano-rpc/src/Cardano/Rpc/Server/Internal/UtxoRpc/Type.hs | Adds timestamp field to mkChainPointMsg and introduces a corresponding decode helper. |
| cardano-rpc/test/cardano-rpc-test/Test/Cardano/Rpc/Type.hs | Adds a ChainPoint protobuf roundtrip property including timestamp. |
| cardano-rpc/cardano-rpc.cabal | Adds time as a library dependency. |
| cardano-api/src/Cardano/Api/Query/Internal/Type/QueryInMode.hs | Introduces slotToUTCTime conversion helper. |
| cardano-api/src/Cardano/Api/Query.hs | Re-exports slotToUTCTime. |
| cardano-api/src/Cardano/Api/Internal/Orphans/Misc.hs | Adds Error PastHorizonException instance to support error handling in callers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Tested in:
Checklist