Skip to content

Fix: HBO in CIccCLUT::Interp3d()#637

Merged
xsscx merged 2 commits intomasterfrom
issue-620
Mar 1, 2026
Merged

Fix: HBO in CIccCLUT::Interp3d()#637
xsscx merged 2 commits intomasterfrom
issue-620

Conversation

@ChrisCoxArt
Copy link
Contributor

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner March 1, 2026 02:39
@xsscx xsscx self-assigned this Mar 1, 2026
@xsscx xsscx added PR Pull Request Review in Process Issue is being Reviewed by Maintainers Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process Issue is being Reviewed by Maintainers pending labels Mar 1, 2026
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer Review

2026-03-01 02:47:43 UTC

Host

Linux 6.6.87.2-microsoft-standard-WSL2 #1 SMP PREEMPT_DYNAMIC Thu Jun  5 18:30:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Repro

mkdir pr-637
cd pr-637
git clone https://github.com/InternationalColorConsortium/iccDEV.git
cd iccDEV
git fetch origin pull/637/head:pr-637
git checkout pr-637
cd Build
cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Debug -Wno-dev -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-sanitize=leak -fno-omit-frame-pointer -Wall" -DENABLE_TOOLS=ON -DENABLE_STATIC_LIBS=ON -DENABLE_SHARED_LIBS=ON Cmake > cmake.log 2>&1
make -j32
wget https://github.com/xsscx/fuzz/raw/refs/heads/master/graphics/icc/npd-CIccMpeCalculator-GetNewApply-IccMpeCalc_cpp-Line4929.icc
printf "'RGB '\nicEncodeFloat\n0.5 0.5 0.5\n" | iccApplyNamedCmm /dev/stdin 3 0 npd-CIccMpeCalculator-GetNewApply-IccMpeCalc_cpp-Line4929.icc 0

Expected Output

'XYZ '  ; Data Format
icEncodeFloat   ; Encoding

;Source Data Format: 'RGB '
;Source Data Encoding: icEncodeFloat
;Source data is after semicolon

;Profiles applied
; npd-CIccMpeCalculator-GetNewApply-IccMpeCalc_cpp-Line4929.icc

    0.0000    0.0000    0.0000  ;    0.5000    0.5000    0.5000

@xsscx xsscx changed the title Make function pointer more obvious, clamp negative values Fix: HBO in CIccCLUT::Interp3d() Mar 1, 2026
@xsscx xsscx merged commit 04025bd into master Mar 1, 2026
27 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Mar 1, 2026
@xsscx xsscx linked an issue Mar 1, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged Merged PR Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HBO in CIccCLUT::Interp3d() at IccTagLut.cpp:2721

2 participants