Skip to content

Fix: HBO in CIccCalculatorFunc::ApplySequence()#635

Merged
xsscx merged 1 commit intomasterfrom
issue-623
Mar 1, 2026
Merged

Fix: HBO in CIccCalculatorFunc::ApplySequence()#635
xsscx merged 1 commit intomasterfrom
issue-623

Conversation

@ChrisCoxArt
Copy link
Contributor

Fixes #623

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner March 1, 2026 01:47
@xsscx xsscx self-assigned this Mar 1, 2026
@xsscx xsscx added PR Pull Request Review in Process Issue is being Reviewed by Maintainers Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process Issue is being Reviewed by Maintainers pending labels Mar 1, 2026
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer Review

2026-03-01 01:58:04 UTC

mkdir pr-635
cd pr-635
git clone https://github.com/InternationalColorConsortium/iccDEV.git
cd iccDEV
git fetch origin pull/635/head:pr-635
git checkout pr-635
cd Build
cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Debug -Wno-dev -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-sanitize=leak -fno-omit-frame-pointer -Wall" -DENABLE_TOOLS=ON -DENABLE_STATIC_LIBS=ON -DENABLE_SHARED_LIBS=ON Cmake > cmake.log 2>&1
make -j32
wget https://github.com/xsscx/fuzz/raw/refs/heads/master/graphics/icc/hbo-CIccCalculatorFunc-ApplySequence-IccMpeCalc_cpp-Line3715.icc
printf "'RGB '\nicEncodeFloat\n0.5 0.5 0.5\n" | ASAN_OPTIONS=detect_leaks=0,print_scariness=1 Tools/IccApplyNamedCmm/iccApplyNamedCmm /dev/stdin 3 0 hbo-CIccCalculatorFunc-ApplySequence-IccMpeCalc_cpp-Line3715.icc 0

Expected Output

[2026-03-01 01:57:45 UTC] ~/pr-635/iccDEV/Build (pr-635)$ git log --oneline --graph -1
* 82df008 (HEAD -> pr-635, origin/issue-623) Check offsets before calling ApplySequence
[2026-03-01 01:57:48 UTC] ~/pr-635/iccDEV/Build (pr-635)$ printf "'RGB '\nicEncodeFloat\n0.5 0.5 0.5\n" | ASAN_OPTIONS=detect_leaks=0,print_scariness=1 Tools/IccApplyNamedCmm/iccApplyNamedCmm /dev/stdin 3 0 hbo-CIccCalculatorFunc-ApplySequence-IccMpeCalc_cpp-Line3715.icc 0
'XYZ '  ; Data Format
icEncodeFloat   ; Encoding

;Source Data Format: 'RGB '
;Source Data Encoding: icEncodeFloat
;Source data is after semicolon

;Profiles applied
; hbo-CIccCalculatorFunc-ApplySequence-IccMpeCalc_cpp-Line3715.icc

   -1.0000   -1.0000   -1.0000  ;    0.5000    0.5000    0.5000

@xsscx xsscx changed the title Check offsets before calling ApplySequence Fix: HBO in CIccCalculatorFunc::ApplySequence() Mar 1, 2026
@xsscx xsscx merged commit b0357b8 into master Mar 1, 2026
27 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged Merged PR Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HBO in CIccCalculatorFunc::ApplySequence() at IccMpeCalc.cpp:3711

2 participants