Skip to content

Fix: SBO in icFixXml()#634

Merged
xsscx merged 1 commit intomasterfrom
issue-624
Mar 1, 2026
Merged

Fix: SBO in icFixXml()#634
xsscx merged 1 commit intomasterfrom
issue-624

Conversation

@ChrisCoxArt
Copy link
Contributor

@ChrisCoxArt ChrisCoxArt commented Mar 1, 2026

Fixes #624

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner March 1, 2026 01:08
@xsscx xsscx self-assigned this Mar 1, 2026
@xsscx xsscx added PR Pull Request Review in Process Issue is being Reviewed by Maintainers labels Mar 1, 2026
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer Review

2026-03-01 01:12:01 UTC

mkdir pr-634
cd pr-634
git clone https://github.com/InternationalColorConsortium/iccDEV.git
cd iccDEV
git fetch origin pull/634/head:pr-634
git checkout pr-634
cd Build
cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Debug -Wno-dev -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-sanitize=leak -fno-omit-frame-pointer -Wall" -DENABLE_TOOLS=ON -DENABLE_STATIC_LIBS=ON -DENABLE_SHARED_LIBS=ON Cmake > cmake.log 2>&1
make -j32
wget https://github.com/xsscx/fuzz/raw/refs/heads/master/graphics/icc/sbo-icFixXml-IccUtilXml_cpp-Line314.icc
Tools/IccToXml/iccToXml sbo-icFixXml-IccUtilXml_cpp-Line314.icc foo.bar

Expected Output

[2026-03-01 01:12:17 UTC] ~/pr-634/iccDEV/Build (pr-634)$ git log --oneline --graph -1
* da22c53 (HEAD -> pr-634, origin/issue-624) make sure prefix and suffix are null terminated
[2026-03-01 01:12:18 UTC] ~/pr-634/iccDEV/Build (pr-634)$ Tools/IccToXml/iccToXml sbo-icFixXml-IccUtilXml_cpp-Line314.icc foo.bar
XML successfully created

@xsscx xsscx added Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process Issue is being Reviewed by Maintainers labels Mar 1, 2026
@xsscx xsscx changed the title make sure named color prefix and suffix are null terminated Fix: SBO in icFixXml() Mar 1, 2026
@xsscx xsscx merged commit cd0a6c7 into master Mar 1, 2026
27 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes pending labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged Merged PR Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SBO in icFixXml() at IccUtilXml.cpp:314

2 participants