Conversation
xsscx
approved these changes
Mar 1, 2026
Member
xsscx
left a comment
There was a problem hiding this comment.
Maintainer Review
2026-03-01 01:12:01 UTC
mkdir pr-634
cd pr-634
git clone https://github.com/InternationalColorConsortium/iccDEV.git
cd iccDEV
git fetch origin pull/634/head:pr-634
git checkout pr-634
cd Build
cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Debug -Wno-dev -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-sanitize=leak -fno-omit-frame-pointer -Wall" -DENABLE_TOOLS=ON -DENABLE_STATIC_LIBS=ON -DENABLE_SHARED_LIBS=ON Cmake > cmake.log 2>&1
make -j32
wget https://github.com/xsscx/fuzz/raw/refs/heads/master/graphics/icc/sbo-icFixXml-IccUtilXml_cpp-Line314.icc
Tools/IccToXml/iccToXml sbo-icFixXml-IccUtilXml_cpp-Line314.icc foo.bar
Expected Output
[2026-03-01 01:12:17 UTC] ~/pr-634/iccDEV/Build (pr-634)$ git log --oneline --graph -1
* da22c53 (HEAD -> pr-634, origin/issue-624) make sure prefix and suffix are null terminated
[2026-03-01 01:12:18 UTC] ~/pr-634/iccDEV/Build (pr-634)$ Tools/IccToXml/iccToXml sbo-icFixXml-IccUtilXml_cpp-Line314.icc foo.bar
XML successfully created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #624
Pull Request Checklist