Skip to content

Fix: SBO in CIccPcsXform::pushXYZConvert()#632

Merged
xsscx merged 1 commit intomasterfrom
issue-625
Mar 1, 2026
Merged

Fix: SBO in CIccPcsXform::pushXYZConvert()#632
xsscx merged 1 commit intomasterfrom
issue-625

Conversation

@ChrisCoxArt
Copy link
Contributor

Fixes #625

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner March 1, 2026 00:38
@xsscx xsscx self-assigned this Mar 1, 2026
@xsscx xsscx added PR Pull Request Review in Process Issue is being Reviewed by Maintainers Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process Issue is being Reviewed by Maintainers labels Mar 1, 2026
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer Review

2026-03-01 00:52:30 UTC

mkdir pr-632
cd pr-632
git clone https://github.com/InternationalColorConsortium/iccDEV.git
cd iccDEV
git fetch origin pull/632/head:pr-632
git checkout pr-632
cd Build
cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Debug -Wno-dev -DCMAKE_CXX_FLAGS="-g -fsanitize=address,undefined -fno-sanitize=leak -fno-omit-frame-pointer -Wall" -DENABLE_TOOLS=ON -DENABLE_STATIC_LIBS=ON -DENABLE_SHARED_LIBS=ON Cmake > cmake.log 2>&1
make -j32
wget https://github.com/xsscx/fuzz/raw/refs/heads/master/graphics/icc/hbo-CIccPcsXform-pushXYZConvert-IccCmm_cpp-Line3000.icc
wget https://github.com/xsscx/fuzz/raw/refs/heads/master/graphics/icc/hbo-CIccPcsXform-pushXYZConvert-IccCmm_cpp-Line3000-part2.icc
printf "'RGB '\nicEncodeFloat\n0.5\t0.5\t0.5\n" | Tools/IccApplyNamedCmm/iccApplyNamedCmm /dev/stdin 3 1 hbo-CIccPcsXform-pushXYZConvert-IccCmm_cpp-Line3000.icc 1 hbo-CIccPcsXform-pushXYZConvert-IccCmm_cpp-Line3000-part2.icc 1

Expected Output

Error 14 - Unable to begin profile application - Possibly invalid or incompatible profiles

@xsscx xsscx changed the title validate size of matrix matches expected, and don't overread the buffer Fix: SBO in CIccPcsXform::pushXYZConvert() Mar 1, 2026
@xsscx xsscx self-requested a review March 1, 2026 00:55
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2026-03-01 00:56:10 UTC

@xsscx xsscx merged commit 497f3ce into master Mar 1, 2026
27 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes pending labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged Merged PR Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SBO in CIccPcsXform::pushXYZConvert() at IccCmm.cpp:3000

2 participants