Skip to content

Fix: SO in CIccBasicStructFactory::CreateStruct()#630

Merged
xsscx merged 1 commit intomasterfrom
issue-629
Mar 1, 2026
Merged

Fix: SO in CIccBasicStructFactory::CreateStruct()#630
xsscx merged 1 commit intomasterfrom
issue-629

Conversation

@ChrisCoxArt
Copy link
Contributor

@ChrisCoxArt ChrisCoxArt commented Feb 28, 2026

Fixes #629

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner February 28, 2026 22:56
@xsscx xsscx self-assigned this Feb 28, 2026
@xsscx xsscx added PR Pull Request Review in Process Issue is being Reviewed by Maintainers labels Feb 28, 2026
xsscx
xsscx approved these changes Feb 28, 2026
View reviewed changes
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2026-02-28 23:40:22 UTC

@xsscx xsscx added Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process Issue is being Reviewed by Maintainers labels Feb 28, 2026
@xsscx xsscx changed the title check tag sizes before getting into an infinite loop Fix: SO in CIccBasicStructFactory::CreateStruct() Mar 1, 2026
@xsscx xsscx merged commit 05475ef into master Mar 1, 2026
27 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes pending labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xsscx xsscx xsscx approved these changes

Assignees

@xsscx xsscx

Labels

Merged Merged PR Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SO in CIccBasicStructFactory::CreateStruct() at IccStructFactory.cpp:93

2 participants

@ChrisCoxArt @xsscx