Skip to content

Fix: HUAF in CIccCmm::AddXform()#616

Merged
xsscx merged 1 commit intomasterfrom
issue-612
Feb 24, 2026
Merged

Fix: HUAF in CIccCmm::AddXform()#616
xsscx merged 1 commit intomasterfrom
issue-612

Conversation

@ChrisCoxArt
Copy link
Contributor

Fixes #612

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner February 23, 2026 23:59
@xsscx xsscx self-assigned this Feb 24, 2026
@xsscx xsscx added PR Pull Request Review in Process Issue is being Reviewed by Maintainers Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process Issue is being Reviewed by Maintainers labels Feb 24, 2026
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer Review

2026-02-24 00:28:01 UTC

~/pr616/iccDEV/Build (pr-616)$ Tools/IccApplyProfiles/iccApplyProfiles test_8x8.tif /tmp/out.tif 1 0 1 1 1 huaf-CIccCmm-AddXform-IccCmm_cpp-Line8320.icc 1
_TIFFVSetField: /tmp/out.tif: Bad value 0 for "SamplesPerPixel" tag.
100%

@xsscx xsscx changed the title check profile before CreateXform deletes the profile Fix: HUAF in CIccCmm::AddXform() Feb 24, 2026
@xsscx xsscx merged commit cf28ef4 into master Feb 24, 2026
27 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes pending labels Feb 24, 2026
@ChrisCoxArt ChrisCoxArt deleted the issue-612 branch March 1, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged Merged PR Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HUAF in CIccCmm::AddXform() at IccCmm.cpp:8320

2 participants