Add: Dockerfiles for Packages by xsscx · Pull Request #597 · InternationalColorConsortium/iccDEV

xsscx · 2026-02-11T18:57:27Z

Pull Request Checklist

Have you followed the guidelines in Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you built your Pull Request locally with the Build Instructions?
Have you added or updated relevant tests?
Have you added or updated relevant docs?

Copilot

Pull request overview

This pull request adds Docker containerization support for the iccDEV project, introducing two Dockerfiles to build and distribute iccDEV tools and libraries as container images. This aligns with issue #596 to create packages for the GitHub Container Registry.

Changes:

Added multi-stage Dockerfile for Ubuntu-based builds with ASAN/UBSAN instrumentation
Added Dockerfile.nixos for NixOS-based builds with wxWidgets support
Configured containers with pre-built iccDEV tools and libraries accessible via PATH

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 13 comments.

File	Description
Dockerfile	Multi-stage Ubuntu 26.04 build with Clang-18, ASAN, UBSAN, and automated test execution
Dockerfile.nixos	NixOS-based single-stage build using nix-shell with full dependency management

Dockerfile

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Dockerfile

.github/workflows/ci-docker-latest.yml

xsscx · 2026-02-12T00:31:20Z

Status of Outputs

2026-02-13 03:18:19 UTC

Build & Output to Packages

https://github.com/InternationalColorConsortium/iccDEV/actions/runs/21973250681/attempts/1
https://github.com/InternationalColorConsortium/iccDEV/attestations/18842616
https://github.com/InternationalColorConsortium/iccDEV/pkgs/container/iccdev-latest

Need to consider Tags etc.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

.github/workflows/ci-docker-latest.yml

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Copilot · 2026-02-12T01:05:26Z

Dockerfile.nixos

+/workspace/iccDEV/Build/Tools/IccTiffDump:\
+/workspace/iccDEV/Build/Tools/IccToXml:\
+/workspace/iccDEV/Build/Tools/IccV5DspObsToV4Dsp:\
+/workspace/iccDEV/Build/Tools/wxProfileDump:\


The PATH includes "/workspace/iccDEV/Build/Tools/wxProfileDump" but the actual executable built from this directory is named "iccDumpProfileGui" (as defined in Build/Cmake/Tools/wxProfileDump/CMakeLists.txt line 28). This PATH entry should point to the correct directory where iccDumpProfileGui is built, which is likely Build/Tools/wxProfileDump, but the tool name shown in the welcome message (line 99) is correct.

True Positive

Copilot · 2026-02-12T01:05:26Z

Dockerfile

+ && useradd -r -g iccdev -d /opt/iccdev -s /bin/bash iccdev \
+ && chown -R iccdev:iccdev /opt/iccdev
+
+ENV PATH="/opt/iccdev/Build/Tools/IccToXml:/opt/iccdev/Build/Tools/IccFromXml:/opt/iccdev/Build/Tools/IccDumpProfile:/opt/iccdev/Build/Tools/IccApplyNamedCmm:/opt/iccdev/Build/Tools/IccRoundTrip:/opt/iccdev/Build/Tools/IccFromCube:/opt/iccdev/Build/Tools/IccApplyProfiles:/opt/iccdev/Build/Tools/IccApplySearch:/opt/iccdev/Build/Tools/IccApplyToLink:/opt/iccdev/Build/Tools/IccPngDump:/opt/iccdev/Build/Tools/IccSpecSepToTiff:/opt/iccdev/Build/Tools/IccTiffDump:/opt/iccdev/Build/Tools/IccV5DspObsToV4Dsp:${PATH}"


The PATH environment variable is missing the IccJpegDump tool directory. According to Build/Cmake/CMakeLists.txt line 1093-1094, IccJpegDump is built and should be included. Add "/opt/iccdev/Build/Tools/IccJpegDump" to the PATH to make the iccJpegDump executable available.

Suggested change

ENV PATH="/opt/iccdev/Build/Tools/IccToXml:/opt/iccdev/Build/Tools/IccFromXml:/opt/iccdev/Build/Tools/IccDumpProfile:/opt/iccdev/Build/Tools/IccApplyNamedCmm:/opt/iccdev/Build/Tools/IccRoundTrip:/opt/iccdev/Build/Tools/IccFromCube:/opt/iccdev/Build/Tools/IccApplyProfiles:/opt/iccdev/Build/Tools/IccApplySearch:/opt/iccdev/Build/Tools/IccApplyToLink:/opt/iccdev/Build/Tools/IccPngDump:/opt/iccdev/Build/Tools/IccSpecSepToTiff:/opt/iccdev/Build/Tools/IccTiffDump:/opt/iccdev/Build/Tools/IccV5DspObsToV4Dsp:${PATH}"

ENV PATH="/opt/iccdev/Build/Tools/IccToXml:/opt/iccdev/Build/Tools/IccFromXml:/opt/iccdev/Build/Tools/IccDumpProfile:/opt/iccdev/Build/Tools/IccApplyNamedCmm:/opt/iccdev/Build/Tools/IccRoundTrip:/opt/iccdev/Build/Tools/IccFromCube:/opt/iccdev/Build/Tools/IccApplyProfiles:/opt/iccdev/Build/Tools/IccApplySearch:/opt/iccdev/Build/Tools/IccApplyToLink:/opt/iccdev/Build/Tools/IccPngDump:/opt/iccdev/Build/Tools/IccJpegDump:/opt/iccdev/Build/Tools/IccSpecSepToTiff:/opt/iccdev/Build/Tools/IccTiffDump:/opt/iccdev/Build/Tools/IccV5DspObsToV4Dsp:${PATH}"

True Positive

.github/workflows/ci-docker-latest.yml

xsscx · 2026-02-12T01:15:34Z

This the result of a Copilot Suggestion:

Invalid workflow file: .github/workflows/ci-docker-latest.yml#L1
(Line: 38, Col: 19): Unrecognized function: 'toLower'. Located at position 1 within expression: toLower(github.repository_owner)

xsscx · 2026-02-18T02:02:54Z

Maintainer Review

2026-02-18 02:01:58 UTC

TODO

Dockerfile lines 12,36: ubuntu:26.04 not pinned to digest
Both Dockerfiles: git clone without commit pinning
Dockerfile.nixos: runs as root (no USER directive)

xsscx · 2026-02-18T02:54:11Z

Maintainer Notes

2026-02-18 02:46:56 UTC

Docker Reviews

To Approve a Code Review for Docker Container and related Workflows please validate:

ubuntu:image must sha pin to commit
Checkout steps must sha pin to commit
Shell prologue is standardized on ci-pr-actions
Required to include SBOM & Attest
Zero ${{ }} in run blocks
All matrix/needs via env:
sanitize_line() on STEP_SUMMARY
sanitize_print() on docker output
No sanitize-sed.sh inside containers
$GITHUB_ENV / $GITHUB_STEP_SUMMARY quoted
COPY instead of git clone
No root user

xsscx · 2026-02-18T03:13:00Z

Post Merge Summary

2026-02-18 03:11:57 UTC

Docker Image for iccdev:latest pushed to Packages with Latest Tag
Docker Image for iccdev-nixos:latest pushed to Packages with Latest Tag

xsscx requested a review from ChrisCoxArt February 11, 2026 18:57

xsscx self-assigned this Feb 11, 2026

Copilot AI review requested due to automatic review settings February 11, 2026 18:57

xsscx added PR Pull Request Merge Ready Maintainer indicates Merge Ready Docker Docker Information CI labels Feb 11, 2026

xsscx linked an issue Feb 11, 2026 that may be closed by this pull request

Add: Dockerfile Configs for Packages #596

Closed

Copilot started reviewing on behalf of xsscx February 11, 2026 18:57 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

xsscx added Test Status Maintainer indicates TEST Status and removed Merge Ready Maintainer indicates Merge Ready labels Feb 11, 2026

xsscx mentioned this pull request Feb 11, 2026

Add: CMake option to disable wxWidgets support #598

Open

xsscx force-pushed the dockerfiles branch from 382e38a to b52b122 Compare February 11, 2026 23:52

xsscx requested a review from dwtza as a code owner February 11, 2026 23:52

xsscx requested a review from Copilot February 11, 2026 23:59

Copilot started reviewing on behalf of xsscx February 12, 2026 00:00 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

.github/workflows/ci-docker-latest.yml Show resolved Hide resolved

.github/workflows/ci-docker-latest.yml Outdated Show resolved Hide resolved

.github/workflows/ci-docker-latest.yml Show resolved Hide resolved

xsscx force-pushed the dockerfiles branch 2 times, most recently from d2a66d1 to adb5486 Compare February 12, 2026 00:16

xsscx requested a review from Copilot February 12, 2026 00:29

Copilot started reviewing on behalf of xsscx February 12, 2026 00:29 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

.github/workflows/ci-docker-latest.yml Show resolved Hide resolved

.github/workflows/ci-docker-latest.yml Outdated Show resolved Hide resolved

xsscx requested a review from Copilot February 12, 2026 01:00

xsscx added the Copilot Review Reviewed by Copilot label Feb 12, 2026

Copilot started reviewing on behalf of xsscx February 12, 2026 01:00 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

xsscx force-pushed the dockerfiles branch from adb5486 to 0683c82 Compare February 12, 2026 01:20

xsscx force-pushed the dockerfiles branch from a544f65 to 9467561 Compare February 18, 2026 01:06

xsscx force-pushed the dockerfiles branch from 38ad42d to 2874707 Compare February 18, 2026 02:25

github-actions bot added the pending label Feb 18, 2026

Add: Dockerfiles & Workflows

cf23f2b

xsscx force-pushed the dockerfiles branch from 0d35740 to cf23f2b Compare February 18, 2026 02:39

xsscx added Merge Ready Maintainer indicates Merge Ready and removed Review in Process Issue is being Reviewed by Maintainers Test Status Maintainer indicates TEST Status labels Feb 18, 2026

xsscx merged commit 8cfeaec into master Feb 18, 2026
48 checks passed

xsscx added Merged Merged and removed Merge Ready Maintainer indicates Merge Ready pending labels Feb 18, 2026

xsscx deleted the dockerfiles branch February 25, 2026 02:11

Conversation

xsscx commented Feb 11, 2026

Pull Request Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xsscx commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status of Outputs

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

xsscx Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

xsscx Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

xsscx commented Feb 12, 2026

Uh oh!

xsscx commented Feb 18, 2026

Maintainer Review

TODO

Uh oh!

xsscx commented Feb 18, 2026

Maintainer Notes

Docker Reviews

Uh oh!

Uh oh!

xsscx commented Feb 18, 2026

Post Merge Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xsscx commented Feb 12, 2026 •

edited

Loading