Skip to content

Add Robin PR review workflow - #42

Closed
VineeTagarwaL-code wants to merge 2 commits into
mainfrom
chore/add-robin-review
Closed

VineeTagarwaL-code wants to merge 2 commits into
mainfrom
chore/add-robin-review

Conversation

@VineeTagarwaL-code

Copy link
Copy Markdown
Collaborator

Adds the Robin review workflow, the same file used in interfaze, interfaze-landing and defaultmodel-landing. It needs the LLM_API_KEY, LLM_BASE_URL and LLM_MODEL repo secrets to run.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

🏹 Robin

✅ Review done. I flagged 1 thing worth a look.

Push fixes whenever you like, then comment /robin for another pass.

Robin v2.8.0 · yoeven/robin@main (e75fa54) · diff-only review (model has no tool support)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏹 Robin

Heads up: this is a point-in-time review. Push fixes freely, then comment /robin whenever you want another pass.

⚠️ 1 Medium

Summary

The workflow delegates review logic to a reusable workflow and explicitly passes only the intended secrets rather than inheriting all repository secrets. However, the external workflow is referenced through a mutable branch while receiving an API key and write-capable permissions, creating a supply-chain risk.


Robin — the Robin Hood of code review. Free for every PR.


jobs:
review:
uses: yoeven/robin/.github/workflows/review.yml@main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robin — ⚠️ MEDIUM · confidence: high

The external reusable workflow is loaded from mutable @main. Upstream changes can therefore execute without a change to this repository, with access to the supplied LLM_API_KEY and pull-request write permissions. A compromised upstream workflow could expose the key or misuse those permissions.

Recommendation: Pin the reusable workflow to a reviewed full commit SHA and update that pin through reviewed dependency updates.

uses: yoeven/robin/.github/workflows/review.yml@<reviewed-full-commit-sha>

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

🏹 Robin

✅ Review done. I flagged 1 thing worth a look.

Push fixes whenever you like, then comment /robin for another pass.

Robin v2.8.0 · yoeven/robin@main (e75fa54) · diff-only review (model has no tool support)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏹 Robin

Heads up: this is a point-in-time review. Push fixes freely, then comment /robin whenever you want another pass.

⚠️ 1 Medium

Summary

The workflow keeps integration simple by delegating review logic and explicitly declaring permissions and secrets. The main concern is that a mutable third-party workflow receives an API key and a write-capable GitHub token.


Robin — the Robin Hood of code review. Free for every PR.


jobs:
review:
uses: yoeven/robin/.github/workflows/review.yml@main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robin — ⚠️ MEDIUM · confidence: high

Referencing the external reusable workflow at @main allows upstream changes to execute without any change or review in this repository. That workflow receives LLM_API_KEY and pull-requests write permission, so an upstream compromise could expose the credential or modify pull requests.

Recommendation: Pin the reusable workflow to a reviewed full commit SHA and update that pin through reviewed dependency-update pull requests.

@VineeTagarwaL-code

Copy link
Copy Markdown
Collaborator Author

Closing: Robin is for internal repos only.

@VineeTagarwaL-code
VineeTagarwaL-code deleted the chore/add-robin-review branch October 27, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants