Repository navigation
Add Robin PR review workflow - #42
VineeTagarwaL-code wants to merge 2 commits into
Conversation
🏹 Robin✅ Review done. I flagged 1 thing worth a look. Push fixes whenever you like, then comment Robin v2.8.0 · yoeven/robin@main (e75fa54) · diff-only review (model has no tool support) |
There was a problem hiding this comment.
🏹 Robin
Heads up: this is a point-in-time review. Push fixes freely, then comment
/robinwhenever you want another pass.
Summary
The workflow delegates review logic to a reusable workflow and explicitly passes only the intended secrets rather than inheriting all repository secrets. However, the external workflow is referenced through a mutable branch while receiving an API key and write-capable permissions, creating a supply-chain risk.
Robin — the Robin Hood of code review. Free for every PR.
|
|
||
| jobs: | ||
| review: | ||
| uses: yoeven/robin/.github/workflows/review.yml@main |
There was a problem hiding this comment.
Robin —
The external reusable workflow is loaded from mutable @main. Upstream changes can therefore execute without a change to this repository, with access to the supplied LLM_API_KEY and pull-request write permissions. A compromised upstream workflow could expose the key or misuse those permissions.
Recommendation: Pin the reusable workflow to a reviewed full commit SHA and update that pin through reviewed dependency updates.
uses: yoeven/robin/.github/workflows/review.yml@<reviewed-full-commit-sha>
🏹 Robin✅ Review done. I flagged 1 thing worth a look. Push fixes whenever you like, then comment Robin v2.8.0 · yoeven/robin@main (e75fa54) · diff-only review (model has no tool support) |
There was a problem hiding this comment.
🏹 Robin
Heads up: this is a point-in-time review. Push fixes freely, then comment
/robinwhenever you want another pass.
Summary
The workflow keeps integration simple by delegating review logic and explicitly declaring permissions and secrets. The main concern is that a mutable third-party workflow receives an API key and a write-capable GitHub token.
Robin — the Robin Hood of code review. Free for every PR.
|
|
||
| jobs: | ||
| review: | ||
| uses: yoeven/robin/.github/workflows/review.yml@main |
There was a problem hiding this comment.
Robin —
Referencing the external reusable workflow at @main allows upstream changes to execute without any change or review in this repository. That workflow receives LLM_API_KEY and pull-requests write permission, so an upstream compromise could expose the credential or modify pull requests.
Recommendation: Pin the reusable workflow to a reviewed full commit SHA and update that pin through reviewed dependency-update pull requests.
|
Closing: Robin is for internal repos only. |
Adds the Robin review workflow, the same file used in interfaze, interfaze-landing and defaultmodel-landing. It needs the LLM_API_KEY, LLM_BASE_URL and LLM_MODEL repo secrets to run.