Open
Conversation
DmitriyMV
force-pushed
the
fix-socks5-udp
branch
3 times, most recently
from
6bfd62b to
de3c283
Compare
Right now if UDP receives empty message, it goes into hot loop (consuming entire core). This is probably not something that was intented. Fix is two part: * Close the udp session on error. * After the empty message wait at least 50ms before attempting again.
DmitriyMV
force-pushed
the
fix-socks5-udp
branch
from
de3c283 to
2eccb4d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Required Pre-Submission Checklist
devbranch (NOTmaster)masterbranch is ONLY updated when a new release is createdmasterwill be REJECTEDPull Request Details
Type of Change
Related GitHub Issue
#89
Platform(s) Affected
macOS Application Changes
Does this pull request include changes to the macOS application?
Description of Changes
Right now if UDP receives empty message, it goes into hot loop (consuming entire core). This is probably not something that was intended. This PR provides an example of how it can be fixed, but I leave it to you how would you actually implement it. This PR simply demonstrates the flow that will probably be affected.
Fix is two part:
Compilation & Dependencies