Skip to content

Windows: initialize Winsock before proxy host validation (fix localhost config parse/init failure) #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Windows: initialize Winsock before proxy host validation (fix localhost config parse/init failure) #145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d21c753
Initial plan
Copilot May 28, 2026
c36ec8e
fix(windows): initialize winsock before proxy hostname validation
Copilot May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Windows/src/ProxyBridge.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2566,12 +2566,29 @@ PROXYBRIDGE_API BOOL ProxyBridge_MoveRuleToPosition(UINT32 rule_id, UINT32 new_p

PROXYBRIDGE_API BOOL ProxyBridge_SetProxyConfig(ProxyType type, const char* proxy_ip, UINT16 proxy_port, const char* username, const char* password)
{
WSADATA wsa_data;
BOOL winsock_initialized = FALSE;

if (proxy_ip == NULL || proxy_ip[0] == '\0' || proxy_port == 0)
return FALSE;

// Hostname validation may happen before ProxyBridge_Start initializes Winsock.
// Initialize Winsock here so hostnames like "localhost" resolve reliably.
if (WSAStartup(MAKEWORD(2, 2), &wsa_data) == 0)
{
winsock_initialized = TRUE;
}
else
{
return FALSE;
}

// Validate that the hostname/IP can be resolved
if (resolve_hostname(proxy_ip) == 0)
{
WSACleanup();
return FALSE;
}

strncpy_s(g_proxy_host, sizeof(g_proxy_host), proxy_ip, _TRUNCATE);
g_proxy_port = proxy_port;
Expand All @@ -2596,6 +2613,11 @@ PROXYBRIDGE_API BOOL ProxyBridge_SetProxyConfig(ProxyType type, const char* prox
g_proxy_password[0] = '\0';
}

if (winsock_initialized)
{
WSACleanup();
}

return TRUE;
}

Expand Down
Loading