Add examples to user_data Object with the raw, normalized & sha256 values#1
Open
ericduran wants to merge 1 commit intoInteractiveAdvertisingBureau:mainfrom
Open
Add examples to user_data Object with the raw, normalized & sha256 values#1ericduran wants to merge 1 commit intoInteractiveAdvertisingBureau:mainfrom
ericduran wants to merge 1 commit intoInteractiveAdvertisingBureau:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I initially tried to add the examples to the original table as another column but because the SHA256 hashes are rather long it shrinks the description column and prioritized the example column which wasn't the goal.
So I ended up adding the examples below the user data table, I went with an impression example so I left out certain fields like click_id, or landing page out.
I sourced examples from known reference so the GPP example is from the GPP repo, and also added a normalization table for the examples to highlight the raw value being normalized before being SHA256.
I place the example right below the user_data table but happy to move it down to a reference section if we think that makes more sense.