Bugfix: unable to add new projects, issue #68 #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue that was preventing the addition of new projects by modifying the way project tokens are handled and updating code signing configurations.
- Removed the lowercased() transformation on the project token in URL construction.
- Updated DEVELOPMENT_TEAM identifiers in the Xcode project configuration for proper code signing.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PayForMe/Services/NetworkService.swift | Modified URL building by removing the lowercased call on project.token to address bug #68. |
| PayForMe.xcodeproj/project.pbxproj | Updated the DEVELOPMENT_TEAM values across multiple targets to ensure correct code signing setup. |
Owner
Author
|
I'm going to take care of the failing GitHub actions in the next couple of days. It just seems to be outdated tooling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.