Reduce chance for overflow in ParseTime#331
Open
bmwiedemann wants to merge 1 commit intoInterNetNews:mainfrom
Open
Reduce chance for overflow in ParseTime#331bmwiedemann wants to merge 1 commit intoInterNetNews:mainfrom
bmwiedemann wants to merge 1 commit intoInterNetNews:mainfrom
Conversation
Without this patch, an input of 802M (months) could surprisingly produce a negative return value. Use `atoi` to match the type of the tmp variable. This patch was done while reviewing potential year-2038 issues in openSUSE.
Julien-Elie
added
bug
Contributor
|
Thanks Bernhard for the patch! BTW, do not hesitate to tell us if you see other potential Y2038 issues (we still have one opened: #292). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, an input of 802M (months) could surprisingly produce a negative return value.
Use
atoito match the type of thetmpvariable.This patch was done while reviewing potential year-2038 issues in openSUSE.