Skip to content

Add v0.9.5 robustness: config validation, structured errors, geo timeout, minimal preset#80

Open
Copilot wants to merge 12 commits intomainfrom
copilot/add-robustness-improvements
Open

Add v0.9.5 robustness: config validation, structured errors, geo timeout, minimal preset#80
Copilot wants to merge 12 commits intomainfrom
copilot/add-robustness-improvements

Conversation

Copy link

Copilot AI commented Feb 28, 2026

  • Explore code and understand both issues
  • Fix double-wrapping of getSystemInfo in src/index.ts (comment 2878017185)
  • Validate/clamp timeoutMs in src/geo-ip.ts, always use Promise.race, and warn on invalid values (comment 2878017221)
  • Code review and CodeQL checks passed

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Note

  • Explore code and understand both issues
  • Fix double-wrapping of getSystemInfo in src/index.ts (comment 2878017185)
  • Validate/clamp timeoutMs in src/geo-ip.ts, always use Promise.race, and warn on invalid values (comment 2878017221)
  • Code review and CodeQL checks passed

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Changes since #80 opened

  • Removed the preset configuration option and FingerprintPreset type from the public API, configuration interface, and all internal implementations [2f067bd]
  • Modified getSystemInfo function to always collect all fingerprinting data without conditional preset-based filtering [2f067bd]
  • Updated documentation to reflect removal of minimal preset feature from version 0.9.5 roadmap and replaced release section with unreleased changes [2f067bd]
  • Added Macroscope branding and support attribution to the fingerprint demo application [2f067bd]
  • Updated e2e test dependencies in package lockfile [2f067bd]

Copilot AI and others added 3 commits February 28, 2026 15:01
Co-authored-by: IntegerAlex <84370725+IntegerAlex@users.noreply.github.com>
Co-authored-by: IntegerAlex <84370725+IntegerAlex@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented Feb 28, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ IntegerAlex
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

IntegerAlex and others added 2 commits March 3, 2026 18:03
Update the GitHub Actions continuous integration workflow to expand the
Node.js testing

Co-authored-by: gitbot <gitbot@gossorg.in>
Adjust the GitHub Actions workflow configuration to exclude Node.js version 26 from the automated test suite. This version is currently unavailable

Co-authored-by: gitbot <gitbot@gossorg.in>

This comment was marked as outdated.

@IntegerAlex IntegerAlex marked this pull request as ready for review March 3, 2026 12:42
greptile-apps[bot]

This comment was marked as spam.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
IntegerAlex and others added 2 commits March 3, 2026 19:48
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…lizeConfig

Co-authored-by: IntegerAlex <84370725+IntegerAlex@users.noreply.github.com>
…eout in geo-ip.ts

Co-authored-by: IntegerAlex <84370725+IntegerAlex@users.noreply.github.com>
@IntegerAlex
Copy link
Owner

@macroscope-app review

This comment was marked as outdated.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it for me

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on the fix. The changes will replace error as Error with structuredError on lines 243 and 248 to ensure telemetry methods receive properly normalized error objects.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to create the branch macroscope/copilot/add-robustness-improvements. This may be due to your branch protection rules. For more information, see the documentation at https://docs.macroscope.com/fix-it-for-me.

@macroscopeapp

This comment was marked as outdated.

Repository owner deleted a comment from Copilot AI Mar 11, 2026
Repository owner deleted a comment from netlify bot Mar 13, 2026
Repository owner deleted a comment from netlify bot Mar 13, 2026
IntegerAlex and others added 2 commits March 13, 2026 11:26
Eliminate the FingerprintPreset logic to simplify the system information
collection pipeline. The getSystemInfo function no longer accepts a
preset parameter and

Co-authored-by: gitbot <gitbot@gossorg.in>
Update the project roadmap and branding assets to reflect current
development priorities and new partnerships. The future roadmap data

Co-authored-by: gitbot <gitbot@gossorg.in>
@IntegerAlex
Copy link
Owner

@macroscope-app review

@macroscopeapp
Copy link

macroscopeapp bot commented Mar 13, 2026

Review complete — no issues found. View results: Macroscope - Correctness Check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants