LTI: поддержка протокола LTI 1.3 для интеграции с внешними инструментами.#655
Open
KirillBorisovich wants to merge 28 commits intoInteIIigeNET:masterfrom
Open
LTI: поддержка протокола LTI 1.3 для интеграции с внешними инструментами.#655KirillBorisovich wants to merge 28 commits intoInteIIigeNET:masterfrom
KirillBorisovich wants to merge 28 commits intoInteIIigeNET:masterfrom
Conversation
…askId and ltiTaskId
…porting from an external tool, and also made validating jwt tokens
…pLinkingReturnController, added a check for matching toolId and course.LtiToolId
DedSec256
changed the title
DedSec256
changed the title
DedSec256
reviewed
Mar 7, 2026
HwProj.CoursesService/HwProj.CoursesService.API/Models/HomeworkTaskLtiLaunchData.cs
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
HwProj.CoursesService/HwProj.CoursesService.API/Models/HomeworkTaskLtiLaunchData.cs
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
HwProj.CoursesService/HwProj.CoursesService.API/Repositories/ITasksRepository.cs
Outdated
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
HwProj.CoursesService/HwProj.CoursesService.API/Services/CoursesService.cs
Outdated
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
HwProj.CoursesService/HwProj.CoursesService.API/Services/CoursesService.cs
Outdated
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
HwProj.APIGateway/HwProj.APIGateway.API/Lti/Models/LtiToolDto.cs
Outdated
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
HwProj.APIGateway/HwProj.APIGateway.API/Lti/Models/LtiDeepLinkingContentItem.cs
Outdated
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
HwProj.APIGateway/HwProj.APIGateway.API/Lti/Services/LtiToolService.cs
Outdated
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
HwProj.APIGateway/HwProj.APIGateway.API/Models/Solutions/UserTaskSolutions.cs
Outdated
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
HwProj.APIGateway/HwProj.APIGateway.API/Lti/Services/LtiToolService.cs
Outdated
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
HwProj.APIGateway/HwProj.APIGateway.API/Lti/Services/LtiKeyService.cs
Outdated
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
HwProj.APIGateway/HwProj.APIGateway.API/Lti/Services/LtiKeyService.cs
Outdated
Show resolved
Hide resolved
DedSec256
reviewed
Mar 7, 2026
Comment on lines
+9
to
+14
| string clientId, | ||
| string toolId, | ||
| string courseId, | ||
| string targetLinkUri, | ||
| string userId, | ||
| string nonce); |
Contributor
There was a problem hiding this comment.
я бы сделал класс с get/init пропертями
Contributor
Author
There was a problem hiding this comment.
это метод, случайно не дописал public
DedSec256
reviewed
Mar 7, 2026
| } | ||
|
|
||
| string tokenString = form["JWT"]!; | ||
| var handler = new JwtSecurityTokenHandler(); |
Contributor
There was a problem hiding this comment.
точно мы должны его пересоздавать? Можно ли инжектить?
DedSec256
reviewed
Mar 7, 2026
|
|
||
| var resultList = new List<object>(); | ||
|
|
||
| if (unverifiedToken.Payload.TryGetValue(itemsClaimName, out var itemsObject)) |
Contributor
There was a problem hiding this comment.
Действительно ли структура такая жидкая?
DedSec256
reviewed
Mar 7, 2026
| <body> | ||
| <p>Задача выбрана. Возвращаемся в HwProj...</p> | ||
| <script> | ||
| var payload = {responsePayloadJson}; |
DedSec256
reviewed
Mar 7, 2026
Contributor
DedSec256
left a comment
DedSec256
left a comment
There was a problem hiding this comment.
Крутая работа!
Вот основные замечания сейчас
DedSec256
reviewed
Mar 7, 2026
HwProj.APIGateway/HwProj.APIGateway.API/Lti/Controllers/LtiDeepLinkingReturnController.cs
Show resolved
Hide resolved
KirillBorisovich
force-pushed
the
feat/lti-development
branch
from
dccfb9f to
7d2c0fb
Compare
DedSec256
reviewed
Apr 5, 2026
|
|
||
| if (keycMemoryCache.TryGetValue(jwksUrl, out JsonWebKeySet? keySet)) | ||
| { | ||
| return keySet!.Keys; |
Contributor
There was a problem hiding this comment.
Suggested change
| return keySet!.Keys; | |
| return keySet?.Keys; |
DedSec256
reviewed
Apr 5, 2026
| var json = await response.Content.ReadAsStringAsync(); | ||
| keySet = new JsonWebKeySet(json); | ||
|
|
||
| if (response.Headers.CacheControl?.NoCache == true || |
Contributor
There was a problem hiding this comment.
response.Headers.CacheControl можно вынести
DedSec256
reviewed
Apr 5, 2026
| return keySet.Keys; | ||
| } | ||
|
|
||
| const int ageByDefault = 24; |
DedSec256
reviewed
Apr 5, 2026
| if (taskViewModel.LtiLaunchData != null && !string.IsNullOrEmpty(taskViewModel.LtiLaunchData.LtiLaunchUrl)) | ||
| { | ||
| await _tasksRepository.AddOrUpdateLtiLaunchDataAsync(taskId, taskViewModel.LtiLaunchData.ToLtiLaunchData()!); | ||
| } |
Contributor
There was a problem hiding this comment.
Переопределить AddAsync можно, перенести логику с добавлением туда.
DedSec256
reviewed
Apr 5, 2026
Comment on lines
+48
to
+50
| var taskViewModel = task.ToHomeworkTaskViewModel(); | ||
| await _tasksService.FillTaskViewModelWithLtiLaunchDataAsync(taskViewModel, taskId); | ||
|
|
Contributor
There was a problem hiding this comment.
давай _tasksService.GetTaskAsync будет возвращать HomeworkTaskViewModel, и эта логику будет скрыта там
DedSec256
reviewed
Apr 5, 2026
Comment on lines
+33
to
+35
| var responseViewModel = newHomework.ToHomeworkViewModel(); | ||
|
|
||
| await FillLtiLaunchDataForTasks(responseViewModel); |
Contributor
There was a problem hiding this comment.
давай лучше спрячем в IHomeworksService
DedSec256
reviewed
Apr 5, 2026
| Task<HomeworkTask> GetTaskAsync(long taskId, bool withCriteria = false); | ||
| Task<HomeworkTask> GetForEditingTaskAsync(long taskId); | ||
| Task<LtiLaunchData?> GetTaskLtiDataAsync(long taskId); | ||
| Task<Dictionary<long, LtiLaunchData>> GetLtiDataForTasksAsync(long[] taskIds); |
DedSec256
reviewed
Apr 5, 2026
Comment on lines
+84
to
+85
| LecturerComment = score.Comment, | ||
| Rating = (int)Math.Round(score.ScoreGiven) |
Contributor
There was a problem hiding this comment.
Давай добавим оценку в комментарий
DedSec256
reviewed
Apr 5, 2026
Comment on lines
+89
to
+97
| var solutionId = await solutionsClient.PostSolutionForLti(taskId, postSolutionModel); | ||
|
|
||
| var rate = new RateSolutionModel | ||
| { | ||
| Rating = (int)Math.Round(score.ScoreGiven), | ||
| LecturerComment = score.Comment | ||
| }; | ||
|
|
||
| await solutionsClient.RateSolutionForLti(solutionId, rate); |
Contributor
There was a problem hiding this comment.
Можно объединить в один запрос/метод
DedSec256
reviewed
Apr 5, 2026
| Task<Solution> GetSolutionById(long solutionId); | ||
| Task<Solution[]> GetUserSolutions(long taskId, string studentId); | ||
| Task<long> PostSolution(long taskId, PostSolutionModel model); | ||
| Task<long> PostSolutionForLti(long taskId, PostSolutionModel model); |
DedSec256
reviewed
Apr 5, 2026
| Task<long> PostSolutionForLti(long taskId, PostSolutionModel model); | ||
| Task PostEmptySolutionWithRate(long taskId, SolutionViewModel solution); | ||
| Task RateSolution(long solutionId, RateSolutionModel rateSolutionModel); | ||
| Task RateSolutionForLti(long solutionId, RateSolutionModel rateSolutionModel); |
Contributor
There was a problem hiding this comment.
не должен отправлять уведомления преподавателям
например, во внутреннем вызове PostEmptySolution можно передать флаг
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Реализация поддержки протокола LTI 1.3 для интеграции с внешними инструментами.