COMP: IO modules publicly depend on ImageIOBase

[hjmjohnson]

Move ITKIOImageBase from PRIVATE_DEPENDS to DEPENDS for 4 IO modules whose public headers #include "itkImageIOBase.h" or inherit from ImageIOBase: DCMTK, GE, LSM, and the Philips REC module.

Follows the same fix applied to VTK in #5850. With PRIVATE_DEPENDS, downstream projects that consume these modules' public headers may not receive the transitive include paths and link targets for ITKIOImageBase.

Header analysis confirming public dependency

Each module was verified to have public headers that directly reference ITKIOImageBase types:

• DCMTK: itkDCMTKImageIO.h includes itkImageIOBase.h, DCMTKImageIO inherits from ImageIOBase
• GE: itkGE4ImageIOFactory.h, itkGE5ImageIOFactory.h, itkGEAdwImageIOFactory.h include itkImageIOBase.h
• LSM: itkLSMImageIOFactory.h includes itkImageIOBase.h
• Philips REC: itkPhilipsRECImageIO.h includes itkImageIOBase.h, inherits from ImageIOBase

Not included: ITKIOCSV — its public headers do not reference any IOImageBase types. Its PRIVATE_DEPENDS ITKIOImageBase may be vestigial or only needed for module infrastructure, and warrants separate investigation.

Local build verification

• Configure: passed (ITK 6.0.0, CMake 3.26.6, Ninja, macOS)
• Build: 1145 incremental targets, 0 errors
• Tests: 4/4 IO module tests passed (GE, LSM; DCMTK and Philips REC are EXCLUDE_FROM_DEFAULT)
• Generated module configs verified: ITKIOImageBase appears in PUBLIC_DEPENDS and TRANSITIVE_DEPENDS
• gersemi pre-commit check: passed

[greptile-apps]

Greptile Summary

Promotes ITKIOImageBase from PRIVATE_DEPENDS to DEPENDS in four IO modules (DCMTK, GE, LSM, PhilipsREC) whose public headers directly include itkImageIOBase.h or inherit from ImageIOBase, following the same pattern applied to VTK in #5850. All four header inclusions were confirmed in the actual public include files, and the GE module correctly drops its now-empty PRIVATE_DEPENDS block.

Confidence Score: 5/5

Safe to merge — all four changes are correct, minimal, and verified against actual public headers.

Every changed module was confirmed to have public headers that directly include itkImageIOBase.h or inherit from ImageIOBase. The fix is consistent with the precedent set by #5850 for the VTK module. No regressions are introduced; other modules (GDCM, NIFTI, HDF5) already had ITKIOImageBase in DEPENDS and are unaffected.

No files require special attention.

Important Files Changed

Filename	Overview
Modules/IO/DCMTK/itk-module.cmake	Moves ITKIOImageBase from PRIVATE_DEPENDS to DEPENDS; correct because itkDCMTKImageIO.h publicly includes itkImageIOBase.h.
Modules/IO/GE/itk-module.cmake	Moves ITKIOImageBase from PRIVATE_DEPENDS to DEPENDS and removes the now-empty PRIVATE_DEPENDS block; correct because all three GE factory headers publicly include itkImageIOBase.h.
Modules/IO/LSM/itk-module.cmake	Moves ITKIOImageBase to DEPENDS while keeping ITKTIFF in PRIVATE_DEPENDS; correct because itkLSMImageIOFactory.h publicly includes itkImageIOBase.h.
Modules/IO/PhilipsREC/itk-module.cmake	Moves ITKIOImageBase to DEPENDS while keeping ITKZLIB in PRIVATE_DEPENDS; correct because itkPhilipsRECImageIO.h publicly includes itkImageIOBase.h and inherits ImageIOBase.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Before["Before (PRIVATE_DEPENDS)"]
        D1[ITKIODCMTK] -.->|private| B[ITKIOImageBase]
        G1[ITKIOGE] -.->|private| B
        L1[ITKIOLSM] -.->|private| B
        P1[ITKIOPhilipsREC] -.->|private| B
    end

    subgraph After["After (DEPENDS)"]
        D2[ITKIODCMTK] -->|public| B2[ITKIOImageBase]
        G2[ITKIOGE] -->|public| B2
        L2[ITKIOLSM] -->|public| B2
        P2[ITKIOPhilipsREC] -->|public| B2
    end

    subgraph Impact
        C[Downstream consumers] -->|now receive transitive| B2
        note["Public headers include itkImageIOBase.h\nor inherit from ImageIOBase"]
    end

Loading

_{Reviews (2): Last reviewed commit: "COMP: IO modules publicly depend on Imag..." | Re-trigger Greptile}

[hjmjohnson]

/azp run ITK.Windows