Skip to content

WIP: Conform GDCM to use CMAKE_*OUTPUT_DIRECTORY #5708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
blowekamp wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Conform GDCM to use CMAKE_*OUTPUT_DIRECTORY #5708

blowekamp wants to merge 1 commit into from

Conversation

@blowekamp
Copy link
Member

@blowekamp blowekamp commented Dec 22, 2025

Add GDCM support for modern CMAKE_*_OUTPUT_DIRECTORY variables. Removes setting legacy CMake cache variables.

Internlly GDCM still uses the legacy names.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@blowekamp
WIP: Conform GDCM to use CMAKE_*OUTPUT_DIRECTORY
70d892b 
Add GDCM support for modern CMAKE_*_OUTPUT_DIRECTORY
variables. Removes setting legacy CMake cache variables.

Internlly GDCM still uses the legacy names.
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:ThirdParty Issues affecting the ThirdParty module labels Dec 22, 2025
@blowekamp
Copy link
Member Author

blowekamp commented Dec 23, 2025

Comments are welcome before I make the PR to upstream GDCM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malaterre malaterre malaterre approved these changes

@seanm seanm Awaiting requested review from seanm

@thewtex thewtex Awaiting requested review from thewtex

@hjmjohnson hjmjohnson Awaiting requested review from hjmjohnson

@dzenanz dzenanz Awaiting requested review from dzenanz

Assignees

No one assigned

Labels

area:ThirdParty Issues affecting the ThirdParty module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blowekamp @malaterre