Skip to content

Remove or replace vnl_sample from a few more tests #5658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hjmjohnson merged 2 commits into from
Nov 26, 2025
Merged

Remove or replace vnl_sample from a few more tests #5658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51603be
STYLE: Remove #include "vnl/vnl_sample.h" from RegistrationMethodTest_17
N-Dekker Nov 25, 2025
fa35af3
ENH: Replace vnl_sample with `<random>` in SignedDistanceFunction test
N-Dekker Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/Registration/Common/test/itkImageRegistrationMethodTest_17.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

#include "itkTextOutput.h"
#include "itkCommandIterationUpdate.h"
#include "vnl/vnl_sample.h"

namespace
{

Expand Down
14 changes: 8 additions & 6 deletions Modules/Segmentation/SignedDistanceFunction/test/itkPCAShapeSignedDistanceFunctionGTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,13 @@

#include "itkPCAShapeSignedDistanceFunction.h"

#include "vnl/vnl_sample.h"
#include "itkImageRegionIterator.h"
#include "itkEuler2DTransform.h"

#include <gtest/gtest.h>

#include <random> // For mt19937.

/**
* This module tests the functionality of the PCAShapeSignedDistanceFunction
* class.
Expand Down Expand Up @@ -65,7 +66,8 @@ TEST(PCAShapeSignedDistanceFunction, Test)


// set up the random number generator
vnl_sample_reseed();
std::mt19937 randomNumberEngine{};
std::normal_distribution<double> randomNumberDistribution(0.0, 1.0);

// set up the mean image
auto meanImage = ImageType::New();
Expand All @@ -77,7 +79,7 @@ TEST(PCAShapeSignedDistanceFunction, Test)

for (meanImageIt.GoToBegin(); !meanImageIt.IsAtEnd(); ++meanImageIt)
{
ImageType::PixelType randomPixel = vnl_sample_normal(0, 1);
ImageType::PixelType randomPixel = randomNumberDistribution(randomNumberEngine);
meanImageIt.Set(randomPixel);
}

Expand All @@ -99,7 +101,7 @@ TEST(PCAShapeSignedDistanceFunction, Test)

for (pcImageIts[i].GoToBegin(); !pcImageIts[i].IsAtEnd(); ++pcImageIts[i])
{
ImageType::PixelType randomPixel = vnl_sample_normal(0, 1);
ImageType::PixelType randomPixel = randomNumberDistribution(randomNumberEngine);
pcImageIts[i].Set(randomPixel);
}
}
Expand All @@ -112,7 +114,7 @@ TEST(PCAShapeSignedDistanceFunction, Test)

for (unsigned int i = 0; i < NumberOfPCs; ++i)
{
pcStandardDeviations[i] = vnl_sample_normal(0, 1);
pcStandardDeviations[i] = randomNumberDistribution(randomNumberEngine);
}

shape->SetPrincipalComponentStandardDeviations(pcStandardDeviations);
Expand All @@ -126,7 +128,7 @@ TEST(PCAShapeSignedDistanceFunction, Test)

for (unsigned int i = 0; i < numberOfParameters; ++i)
{
parameters[i] = vnl_sample_normal(0, 1);
parameters[i] = randomNumberDistribution(randomNumberEngine);
}

shape->SetParameters(parameters);
Expand Down
Loading