Skip to content

BUG: Fix itkFrequencyImageRegionIterator #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phcerdan merged 1 commit into from
Sep 11, 2024
+11 −4
Merged

BUG: Fix itkFrequencyImageRegionIterator #4845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Modules/Filtering/ImageFrequency/include/itkFrequencyImageRegionConstIteratorWithIndex.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,11 @@ class ITK_TEMPLATE_EXPORT FrequencyImageRegionConstIteratorWithIndex : public Im
void
Init()
{
this->m_FrequencyOrigin = this->m_Image->GetOrigin();
this->m_FrequencySpacing = this->m_Image->GetSpacing();
for (unsigned int dim = 0; dim < ImageType::ImageDimension; ++dim)
{
this->m_FrequencyOrigin[dim] = this->m_Image->GetOrigin()[dim];
this->m_FrequencySpacing[dim] = this->m_Image->GetSpacing()[dim];
}
}

FrequencyType m_FrequencyOrigin;
Expand Down
2 changes: 1 addition & 1 deletion Modules/Filtering/ImageFrequency/include/itkFrequencyImageRegionIteratorWithIndex.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class ITK_TEMPLATE_EXPORT FrequencyImageRegionIteratorWithIndex
public:
/** Standard class type alias. */
using Self = FrequencyImageRegionIteratorWithIndex;
using Superclass = ImageRegionIteratorWithIndex<TImage>;
using Superclass = FrequencyImageRegionConstIteratorWithIndex<TImage>;

/** Types inherited from the Superclass */
using typename Superclass::IndexType;
Expand Down
6 changes: 5 additions & 1 deletion Modules/Filtering/ImageFrequency/test/itkFrequencyIteratorsGTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
#include "itkHalfHermitianToRealInverseFFTImageFilter.h"
#include "itkFFTShiftImageFilter.h"
#include "itkFrequencyBandImageFilter.h" // Simplest of frequency filters for testing
#include "itkFrequencyImageRegionConstIteratorWithIndex.h"
#include "itkFrequencyImageRegionIteratorWithIndex.h"
#include "itkFrequencyFFTLayoutImageRegionConstIteratorWithIndex.h"
#include "itkFrequencyFFTLayoutImageRegionIteratorWithIndex.h"
#include "itkFrequencyHalfHermitianFFTLayoutImageRegionConstIteratorWithIndex.h"
Expand Down Expand Up @@ -264,7 +266,9 @@ compareAllTypesOfIterators(typename TImageType::Pointer image, double difference
// Checks that an iterator that is just constructed by `IteratorType(image, region)` is at the begin.
TEST_F(FrequencyIterators, AreConstructedAtBegin)
{
CheckIteratorsConstructedAtBegin<itk::FrequencyFFTLayoutImageRegionConstIteratorWithIndex,
CheckIteratorsConstructedAtBegin<itk::FrequencyImageRegionConstIteratorWithIndex,
itk::FrequencyImageRegionIteratorWithIndex,
itk::FrequencyFFTLayoutImageRegionConstIteratorWithIndex,
itk::FrequencyFFTLayoutImageRegionIteratorWithIndex,
itk::FrequencyHalfHermitianFFTLayoutImageRegionConstIteratorWithIndex,
itk::FrequencyHalfHermitianFFTLayoutImageRegionIteratorWithIndex,
Expand Down