Conversation
|
sorry, I realize I forgot to review this, ping me if you have time to go back on it and fix the conflicts |
|
Sure, I started checking this yesterday and some fields names were altered by IGN since I made this PR. I'll let you know when this is ok. |
|
Just resolved the conflicts. I'll double check other (unconflicted) examples are fully working |
|
Note that deaths/births example raises (on cell #5) :
|
|
Ah, population_pyramid is ko without any prospect of resetting it right away. It used localdata API which has been discontinued (you are supposed to switch to MELODI). I think we should dig up #213. I also think the test failure is due to localdata's / melody discrepancy. @tfardet what do you think we do on this? Tag the example as obsolete and keep it in the doc for the moment ? Maybe even double check and disable the failing test on EDIT The missing dataset on localdata seems to be the census dataset (dataset_version being |
yes, this definitely needs doing but I've no idea when I might be able to work on this... unlikely any time before the end of the year.
by test failure, you mean
Tagging the example as obsolete sounds good until we can work on updating it.
Yeah, this looks weird, probably the people from INSEE removed some data because this should not be able to fail. |
|
Note: don't merge that one yet, I still need to either fix/tag pyramid. |
Update some examples from the doc:
* that being said: de gustibus and so on... : so if you disagree with the new palettes, no problem for setting it back!