Skip to content

fix: add other types of concept neighbours #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GtanSndil merged 2 commits into from
Dec 11, 2025
Merged

fix: add other types of concept neighbours #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9dc8eb
fix: add other types of concept neighbours
Dec 4, 2025
9fa4000
test: enrich a test
Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion magma-diffusion-impl/src/main/resources/request/concepts/getConceptsByLabel.ftlh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ FILTER(REGEX(STR(?conceptScheme),'/concepts/definitions/scheme'))
FILTER(lang(?intitule) = 'fr')
FILTER(CONTAINS(LCASE(STR(?intitule)), LCASE("${label}")))
BIND(STR(?intitule) AS ?intituleFr)
BIND(EXISTS{?uri dcterms:replaces|^dcterms:replaces ?repl } AS ?hasLink)
BIND(EXISTS{?uri (skos:broader|skos:narrower|skos:related|dcterms:replaces|dcterms:isReplacedBy|skos:closeMatch|dcterms:references) ?repl } AS ?hasLink)
}
ORDER BY ?intituleFr
19 changes: 15 additions & 4 deletions ...st/java/fr/insee/rmes/magma/diffusion/api/testcontainers/queries/ConceptsQueriesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,32 +103,43 @@ void should_return_404_when_ConceptsDefinitionCode_codec1000() throws Exception{
/// concepts/definitions ///
/////////////////////////////////////////////////////////////////////

// geo/concepts/definitions?libelle=elect
// concepts/definitions?libelle=elect
@Test
void should_return_16_concepts_when_ConceptsDefinitions_libelleElect() {
var response = endpoints.getconceptsliste("Élect");
var result = response.getBody();
Assertions.assertNotNull(result);
var resultItem1= result.getFirst();
var resultItem4= result.get(3);
var resultItem6= result.get(5);
assertAll(
() -> assertEquals(16, result.size()),

() -> assertEquals("c1769", resultItem1.getId()),
() -> assertEquals(URI.create("http://id.insee.fr/concepts/definition/c1769"), resultItem1.getUri()),
() -> assertEquals("Commerce électronique", resultItem1.getIntitule()),


() -> assertEquals("c1158", resultItem4.getId()),
() -> assertEquals(URI.create("http://id.insee.fr/concepts/definition/c1158"), resultItem4.getUri()),
() -> assertEquals("Fichier général des électeurs ", resultItem4.getIntitule()),
() -> assertEquals("c2131", resultItem4.getConceptsSuivants().getFirst().getId()),
() -> assertEquals(URI.create("http://id.insee.fr/concepts/definition/c2131"), resultItem4.getConceptsSuivants().getFirst().getUri())
() -> assertEquals(URI.create("http://id.insee.fr/concepts/definition/c2131"), resultItem4.getConceptsSuivants().getFirst().getUri()),

() -> assertEquals("c2169", resultItem6.getId()),
() -> assertEquals(URI.create("http://id.insee.fr/concepts/definition/c2169"), resultItem6.getUri()),
() -> assertEquals("Listes électorales", resultItem6.getIntitule()),
() -> assertEquals("c2167", resultItem6.getConceptsPlusSpecifiques().getFirst().getId()),
() -> assertEquals(URI.create("http://id.insee.fr/concepts/definition/c2167"), resultItem6.getConceptsPlusSpecifiques().getFirst().getUri()),
() -> assertEquals("c2170", resultItem6.getConceptsPlusSpecifiques().get(1).getId()),
() -> assertEquals(URI.create("http://id.insee.fr/concepts/definition/c2170"), resultItem6.getConceptsPlusSpecifiques().get(1).getUri()),
() -> assertEquals("c2171", resultItem6.getConceptsPlusSpecifiques().get(2).getId()),
() -> assertEquals(URI.create("http://id.insee.fr/concepts/definition/c2171"), resultItem6.getConceptsPlusSpecifiques().get(2).getUri())

);
}

// geo/concepts/definitions

// concepts/definitions
@Test
void should_return_1232_concepts_when_ConceptsDefinitions_libelleNull() {
var response = endpoints.getconceptsliste("");
Expand Down