refactor: territory in openapi.yaml#387
Closed
GtanSndil wants to merge 3 commits into110-bis-add-an-openapi-spec-inside-the-projectfrom
Closed
refactor: territory in openapi.yaml#387GtanSndil wants to merge 3 commits into110-bis-add-an-openapi-spec-inside-the-projectfrom
GtanSndil wants to merge 3 commits into110-bis-add-an-openapi-spec-inside-the-projectfrom
Conversation
added 3 commits
October 14, 2025 15:42
mix $ref with other properties is not correct
GtanSndil
changed the title
GtanSndil
changed the title
FBibonne
reviewed
Oct 17, 2025
Member
FBibonne
left a comment
FBibonne
left a comment
There was a problem hiding this comment.
Je ne vois à redire côté technique si l'application compile, que les tests passent et qu'elle démarre bien.
Par contre, si je comprends bien, la spec open api va préciser des attributs de territoire qui pour certains endpoints ne seront jamais renvoyés ou qui seront toujours à null. Je ne sais pas si c'est très bon du point de vue de l'expérience utilisateur. Ou alors j'interprète mal le passage à un seul territoire ?
EmmanuelDemey
approved these changes
Oct 19, 2025
Contributor
Author
|
les modifs souhaitables ont été intégrées dans la PR #399 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.